Skip to content

Conversation

@danielbattistini
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

alibuild commented Jan 28, 2025

Error while checking build/O2/fullCI for f44c5e5 at 2025-01-29 09:50:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:54:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:78:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:109:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:161:27: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Jan 29, 2025

Error while checking build/O2/fullCI_slc9 for 419e6e0 at 2025-01-30 10:04:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13910-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:54:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:79:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:111:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:164:27: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Jan 29, 2025

Error while checking build/O2/fullCI for 419e6e0 at 2025-01-30 10:30:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:54:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:79:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:111:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13910-slc8_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx:164:27: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

Copy link
Collaborator

@mconcas mconcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every if statement needs to be braced.

@mconcas mconcas merged commit 03ea86a into AliceO2Group:dev Jan 30, 2025
12 of 13 checks passed
@danielbattistini danielbattistini deleted the dev-staggered-geo branch February 11, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants