Skip to content

DPL Analysis: remove unnecessary instances of selected_pack #13892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 10 commits into from
Jan 28, 2025
Merged

DPL Analysis: remove unnecessary instances of selected_pack #13892

ktf merged 10 commits into from
Jan 28, 2025

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Jan 23, 2025

No description provided.

@aalkin aalkin requested a review from a team as a code owner January 23, 2025 12:07
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild alibuild mentioned this pull request Jan 23, 2025
Closed
@aalkin aalkin requested a review from ktf January 23, 2025 13:22
@alibuild alibuild mentioned this pull request Jan 24, 2025
Closed
@ktf ktf merged commit 53ed758 into AliceO2Group:dev Jan 28, 2025
12 of 13 checks passed
@ktf
Copy link
Member

ktf commented Jan 28, 2025

Tested also on hyperloop.

@ktf
Copy link
Member

ktf commented Jan 29, 2025

This actually explodes the size of the debug symbols and apparently correlates with some reported O2Physics issue. Reverting for now. (@ddobrigk)

ktf added a commit that referenced this pull request Jan 29, 2025
@ktf
Revert "DPL Analysis: remove unnecessary instances of selected_pack (#…
97f12ef 
…13892)"

This reverts commit 53ed758.
@ktf ktf mentioned this pull request Jan 29, 2025
Merged
ktf added a commit that referenced this pull request Jan 29, 2025
@ktf
Revert "DPL Analysis: remove unnecessary instances of selected_pack (#…
f6ce9ae 
…13892)" (#13913)

This reverts commit 53ed758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktf ktf Awaiting requested review from ktf

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aalkin @ktf