Skip to content

DPL: drop obsolete communication method completely #13888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Jan 22, 2025
Merged

DPL: drop obsolete communication method completely #13888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Framework/Core/src/runDataProcessing.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
#include "Framework/DataTakingContext.h"
#include "Framework/CommonServices.h"
#include "Framework/DefaultsHelpers.h"
#include "ControlServiceHelpers.h"
#include "ProcessingPoliciesHelpers.h"
#include "DriverServerContext.h"
#include "HTTPParser.h"
Expand Down Expand Up @@ -848,9 +847,7 @@ void processChildrenOutput(uv_loop_t* loop,
// TODO: have multiple display modes
// TODO: graphical view of the processing?
assert(infos.size() == controls.size());
std::match_results<std::string_view::const_iterator> match;
ParsedMetricMatch metricMatch;
ParsedConfigMatch configMatch;

int processed = 0;
for (size_t di = 0, de = infos.size(); di < de; ++di) {
Expand Down Expand Up @@ -881,11 +878,7 @@ void processChildrenOutput(uv_loop_t* loop,
// in the GUI.
// Then we check if it is part of our Poor man control system
// if yes, we execute the associated command.
if (logLevel == LogParsingHelpers::LogLevel::Info && ControlServiceHelpers::parseControl(token, match)) {
throw runtime_error("stdout is not supported anymore as a driver backend. Please use ws://");
} else if (logLevel == LogParsingHelpers::LogLevel::Info && DeviceConfigHelper::parseConfig(token.substr(16), configMatch)) {
throw runtime_error("stdout is not supported anymore as a driver backend. Please use ws://");
} else if (!control.quiet && (token.find(control.logFilter) != std::string::npos) && logLevel >= info.logLevel) {
if (!control.quiet && (token.find(control.logFilter) != std::string::npos) && logLevel >= info.logLevel) {
assert(info.historyPos >= 0);
assert(info.historyPos < info.history.size());
info.history[info.historyPos] = token;
Expand Down
Loading