Skip to content

DPL Analysis: avoid calculating indexing columns #13883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 1 commit into from
Jan 22, 2025
Merged

DPL Analysis: avoid calculating indexing columns #13883

ktf merged 1 commit into from
Jan 22, 2025

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jan 21, 2025 •
edited
Loading

All we need to know is that there is at least one for the
constrain to apply.

@ktf ktf requested a review from a team as a code owner January 21, 2025 09:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild alibuild mentioned this pull request Jan 21, 2025
Closed
@ktf
Copy link
Member Author

ktf commented Jan 21, 2025

@aalkin are you working on something overlapping?

ktf
ktf commented Jan 21, 2025
View reviewed changes
Framework/Core/include/Framework/ASoA.h
[this]<typename T>(T*) -> void {},
};
(f(static_cast<C*>(nullptr)), ...);
if constexpr (has_index_v) {
Copy link
Member Author

@ktf ktf Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we should probably move the part above to some "preBind" function with constraints on the type T.

aalkin
aalkin reviewed Jan 21, 2025
View reviewed changes
@ktf
DPL Analysis: avoid calculating indexing columns
21faec9 
All we need to know is that there is at least one for the
constrain to apply.
@ktf ktf changed the title Avoid calculating indexing columns DPL Analysis: avoid calculating indexing columns Jan 22, 2025
@ktf
Copy link
Member Author

ktf commented Jan 22, 2025

Tested separately on macOS. Merging.

@ktf ktf merged commit 89fbec2 into AliceO2Group:dev Jan 22, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aalkin aalkin aalkin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @aalkin