Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Jan 17, 2025

No description provided.

@aalkin aalkin requested a review from a team as a code owner January 17, 2025 11:55
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ktf ktf merged commit 9c5dea2 into AliceO2Group:dev Jan 21, 2025
11 checks passed
@ktf
Copy link
Member

ktf commented Jan 21, 2025

This is fine as a change, however the usage of base_of_template should be seen as a bad pattern, in particular when used together with constraints. We should restrict based on the behaviour of the class, not based on some arbitrary categorisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants