Skip to content

DPL Analysis: fix use-after-delete in expressions #13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Jan 16, 2025
Merged

DPL Analysis: fix use-after-delete in expressions #13869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Framework/Core/src/Expressions.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ size_t Filter::designateSubtrees(Node* node, size_t index)
path.emplace(node, 0);

while (!path.empty()) {
auto& top = path.top();
auto top = path.top();
top.node_ptr->index = local_index;
path.pop();
if (top.node_ptr->condition != nullptr) {
Expand Down Expand Up @@ -277,7 +277,7 @@ Operations createOperations(Filter const& expression)

// while the stack is not empty
while (!path.empty()) {
auto& top = path.top();
auto top = path.top();

// create operation spec, pop the node and add its children
auto operationSpec =
Expand Down Expand Up @@ -458,7 +458,7 @@ std::shared_ptr<gandiva::Filter>
{
std::shared_ptr<gandiva::Filter> filter;
auto s = gandiva::Filter::Make(Schema,
std::move(condition),
condition,
&filter);
if (!s.ok()) {
throw runtime_error_f("Failed to create filter: %s", s.ToString().c_str());
Expand Down
Loading