Skip to content

Conversation

@noferini
Copy link
Collaborator

@noferini noferini commented Jan 4, 2025

FT0 digitization: moving mIntRecord.getTimeOffsetWrtBC() when caching digit in order to use the current (and correct) collision time

Two plots from TOF QC after this commit is included... TOF-FT0 correlation recovered

immagine

immagine

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Double_t hit_time = hit.GetTime() - timeOfFlight + timeOffset;
Double_t hit_time = hit.GetTime() - timeOfFlight + timeOffset + mIntRecord.getTimeOffsetWrtBC();

if (hit_time > 150) {
Copy link
Collaborator

@afurs afurs Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also use hit_time here (hit_time > 150), w/o coll time

@afurs
Copy link
Collaborator

afurs commented Jan 5, 2025

Hello @noferini I suggest to postpone this commit until we check some other cases (marked in the code) where hit_time is used w/o coll time.

@noferini
Copy link
Collaborator Author

noferini commented Jan 5, 2025

Hi @afurs ,
It Is fine.
Then I close the pr.
Cheers
Francesco

@noferini noferini closed this Jan 5, 2025
@afurs afurs reopened this Apr 15, 2025
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@afurs afurs enabled auto-merge (squash) April 17, 2025 06:43
@afurs afurs disabled auto-merge April 17, 2025 06:43
@shahor02 shahor02 merged commit 63bc2e3 into AliceO2Group:dev Apr 17, 2025
24 checks passed
@noferini
Copy link
Collaborator Author

Thanks
Francesco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants