-
Notifications
You must be signed in to change notification settings - Fork 483
Data model: add extra information for run 2 evsel #13810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Please consider the following formatting changes to AliceO2Group#13810
victor-gonzalez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddobrigk Perfect! Thanks!
| run2::V0TriggerChargeA, run2::V0TriggerChargeC, | ||
| run2::NTPCClusters, run2::NSDDSSDClusters); | ||
|
|
||
| using Run2BCInfos = Run2BCInfos_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddobrigk Shouldn't be the 001 in place if there are going to be a converter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victor-gonzalez no, step 1 is to keep using vwrsion 000, then step 2 is to add the converter, and then step 3 is to switch to version 001. This is as intended :-)
|
@ddobrigk Should I merge it? |
|
@pzhristov yes, please! Thanks! I have the converter ready for tomorrow, too. |
Goes hand-in-hand with: alisw/AliPhysics#23817
Run2BCInfos now becomes versioned, Run 2 converter in AliPhysics will immediately generate version
001. An O2Physics converter will be added tomorrow.For reference, data size increase is negligible (
Run2BCInfoscurrently occupies, with this change, 0.2% of the data size even in pp, where it's smallest).