Skip to content

Conversation

@ddobrigk
Copy link
Contributor

Goes hand-in-hand with: alisw/AliPhysics#23817

  • adds extra event selection information to the run 2 converted data by adding:
    • TPCout flag in track flags
    • total number of tpc clusters as part of run2bcinfos
    • total number of SSD+SDD clusters as part of run2bcinfos

Run2BCInfos now becomes versioned, Run 2 converter in AliPhysics will immediately generate version 001. An O2Physics converter will be added tomorrow.

For reference, data size increase is negligible (Run2BCInfos currently occupies, with this change, 0.2% of the data size even in pp, where it's smallest).

@ddobrigk ddobrigk requested a review from a team as a code owner December 17, 2024 10:19
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Please consider the following formatting changes to AliceO2Group#13810
Copy link
Contributor

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddobrigk Perfect! Thanks!

run2::V0TriggerChargeA, run2::V0TriggerChargeC,
run2::NTPCClusters, run2::NSDDSSDClusters);

using Run2BCInfos = Run2BCInfos_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddobrigk Shouldn't be the 001 in place if there are going to be a converter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victor-gonzalez no, step 1 is to keep using vwrsion 000, then step 2 is to add the converter, and then step 3 is to switch to version 001. This is as intended :-)

@pzhristov
Copy link
Contributor

@ddobrigk Should I merge it?

@ddobrigk
Copy link
Contributor Author

@pzhristov yes, please! Thanks! I have the converter ready for tomorrow, too.

@pzhristov pzhristov merged commit d4f11dc into AliceO2Group:dev Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants