Skip to content

Conversation

@sawenzel
Copy link
Collaborator

@sawenzel sawenzel commented Dec 13, 2024

The HybridGen needs to forward event headers from the underlying
generators.

In order to access these, we need to make a protected function public.
Also adding eventHeader treatment to BoxGenerator.

More fixes:

  • clear particle container in EventPool
  • do not modify particle statuses in HybridGen (lead to wrong Geant4 simulations)
  • fix possible segfault in chosing EventPool file

@sawenzel sawenzel requested a review from jackal1-66 as a code owner December 13, 2024 14:12
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 8222c00 at 2024-12-14 13:19:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile mftreco.log
./sim-challenge.logmftreco.log:[14846:internal-dpl-ccdb-backend]: [12:19:04][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logmftreco.log-[14846:internal-dpl-ccdb-backend]: [12:19:04][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mft-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[14846:internal-dpl-ccdb-backend]: [12:19:04][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[14846:internal-dpl-ccdb-backend]: [12:19:04][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1546300800000 (agent_id: alissandra05-1734178742-hDz9SB) with http code: 0
./sim-challenge.log[14846:internal-dpl-ccdb-backend]: [12:19:04][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
./sim-challenge.log[14846:internal-dpl-ccdb-backend]: [12:19:04][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[14846:internal-dpl-ccdb-backend]: [12:19:04][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[14846:internal-dpl-ccdb-backend]: [12:19:04][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mft-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 14846 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 14846 (exit 128)
./sim-challenge.log[INFO]    - First error: [12:19:04][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (14846) had at least one message above severity 5: Unable to find object CTP/Calib/OrbitReset/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[8756:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[8762:TPCDigitizer_4]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
[0 more errors; see full log]

Full log here.

@sawenzel sawenzel force-pushed the swenzel/hybrid_eventheader branch from 8222c00 to 769dfb3 Compare December 15, 2024 18:15
@sawenzel sawenzel requested a review from a team as a code owner December 15, 2024 18:15
@sawenzel sawenzel force-pushed the swenzel/hybrid_eventheader branch 2 times, most recently from f88d85b to e6a57a6 Compare December 15, 2024 18:20
The HybridGen needs to forward event headers from the underlying
generators.

In order to access these, we need to make a protected function public.
Also adding eventHeader treatment to BoxGenerator.

More fixes:
- clear particle container in EventPool
- do not modify particle statuses in HybridGen (lead to wrong Geant4 simulations)
- fix possible segfault in chosing EventPool file
@sawenzel sawenzel force-pushed the swenzel/hybrid_eventheader branch from e6a57a6 to 33f829c Compare December 15, 2024 20:05
@sawenzel sawenzel changed the title HybridGen: Add missing EventHeader propagation HybridGen/EventPool: small fixes, Add missing EventHeader propagation Dec 15, 2024
@sawenzel sawenzel merged commit 8ece2ec into AliceO2Group:dev Dec 16, 2024
13 checks passed
@sawenzel sawenzel deleted the swenzel/hybrid_eventheader branch December 16, 2024 07:50
@alcaliva alcaliva added the async-2024-pp-apass1 Request porting to async-2024-pp-apass1 label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2024-pp-apass1 Request porting to async-2024-pp-apass1 Simulation

Development

Successfully merging this pull request may close these issues.

4 participants