Skip to content

Conversation

@mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Dec 11, 2024

The changes introduce a configurable minimum PT value per track length in the ITS tracking parameters. This allows for more fine-grained control over the minimum PT requirement, which can be useful for different tracking scenarios.

The main changes are:

  • Modify the TrackingParameters struct to include an array of 4 minimum PT values, one for each track length (7, 6, 5, 4).
  • Update the track fitting logic in TrackerTraits::findRoads() to use the appropriate minimum PT value based on the track length.
  • Update the default minimum PT value in TrackingInterface::initialise() to use the new array-based approach.

These changes provide more flexibility in tuning the ITS tracking parameters.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

The changes introduce a configurable minimum PT value per track length in the ITS
tracking parameters. This allows for more fine-grained control over the minimum
PT requirement, which can be useful for different tracking scenarios.

The main changes are:

- Modify the `TrackingParameters` struct to include an array of 4 minimum PT
  values, one for each track length (7, 6, 5, 4).
- Update the track fitting logic in `TrackerTraits::findRoads()` to use the
  appropriate minimum PT value based on the track length.
- Update the default minimum PT value in `TrackingInterface::initialise()` to
  use the new array-based approach.

These changes provide more flexibility in tuning the ITS tracking parameters.
@mpuccio mpuccio force-pushed the mp-branch-1 branch 2 times, most recently from d3e4a62 to 6450331 Compare December 12, 2024 09:21
@alibuild
Copy link
Collaborator

alibuild commented Dec 12, 2024

Error while checking build/O2/fullCI for 6450331 at 2024-12-12 14:09:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13792-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/13792-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.

Full log here.

@mconcas
Copy link
Collaborator

mconcas commented Dec 12, 2024

failures are unrelated. Merging

@mconcas mconcas merged commit 58aec50 into AliceO2Group:dev Dec 12, 2024
9 of 12 checks passed
@mconcas mconcas deleted the mp-branch-1 branch April 22, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants