DCAFitterN: log-throttling for err.messages + user policy for bad CovMat #13789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the linearization errors the covariance matrix of the track propagated to some point may become non-positive defined. In this case an error will be logged (logarithmically throttled), the relevant correlation coefficient of the cov.matrix is redefined to cure the position part of the cov.matrix and further program flow depends on the user settings for DCAFitterN::setBadCovPolicy(v): DCAFitterN::setBadCovPolicy(DCAFitterN::Discard) : abandon fit (default) DCAFitterN::setBadCovPolicy(DCAFitterN::Override) : continue fit with overridden cov.matrix DCAFitterN::setBadCovPolicy(DCAFitterN::OverrideAnFlag): continue fit with overridden cov.matrix but set the propagation failure flag (can be checked using the isPropagationFailure(int cand = 0) method).
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the linearization errors, the covariance matrix of the track propagated to some point may become non-positive defined. In this case, an error will be logged (logarithmically throttled), the relevant correlation coefficient of the cov.matrix is redefined to cure the position part of the cov.matrix and further program flow depends on the user settings for
DCAFitterN::setBadCovPolicy(v):DCAFitterN::setBadCovPolicy(DCAFitterN::Discard) :abandon fit (default)DCAFitterN::setBadCovPolicy(DCAFitterN::Override):continue fit with overridden cov.matrixDCAFitterN::setBadCovPolicy(DCAFitterN::OverrideAnFlag):continue fit with overridden cov.matrix but set the propagation failure flag (can be checked using theisPropagationFailure(int cand = 0)method).