Skip to content

Conversation

@maciacco
Copy link
Contributor

@maciacco maciacco commented Dec 9, 2024

@mpuccio @ddobrigk could you have a look please?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@maciacco maciacco marked this pull request as ready for review December 9, 2024 15:56
@maciacco maciacco requested review from a team as code owners December 9, 2024 15:56
mpuccio
mpuccio previously approved these changes Dec 9, 2024
Copy link
Contributor

@mpuccio mpuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot Mario!

@mpuccio
Copy link
Contributor

mpuccio commented Dec 9, 2024

+async-label async-2024-PbPb-apass1, async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

alibuild commented Dec 9, 2024

Error while checking build/O2/fullCI_slc9 for 77a35ae at 2024-12-09 18:05:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk
Copy link
Contributor

Thanks a lot @mpuccio , looks good to me!

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 77a35ae at 2024-12-12 04:23:

## sw/BUILD/o2codechecker-latest/log
100% tests passed, 0 tests failed out of 1


## sw/BUILD/Rivet-latest/log
make[2]: *** [Makefile:544: core.cpp] Error 127
make[1]: *** [Makefile:440: all-recursive] Error 1
make: *** [Makefile:561: all-recursive] Error 1

Full log here.

@pzhristov pzhristov merged commit deecd31 into AliceO2Group:dev Dec 12, 2024
12 of 14 checks passed
@ddobrigk
Copy link
Contributor

@maciacco @mpuccio just for completeness and FYI, there was something very sneaky that I overlooked when I looked at this PR... see here the fix: #13799 (basically, equivalency declarations of A-B and B-C are not equivalent to declaring A-C equivalent I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants