-
Notifications
You must be signed in to change notification settings - Fork 483
Adding MFT covariances in AOD associated with global muon tracks #13780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI for 872b14f at 2025-01-01 03:44: Full log here. |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me, but since it concerns AOD, I think @ddobrigk should approve it.
|
hi @mcoquet642 , sorry for only looking at this now. The code looks okay to me - could you just confirm that this still conforms to the data increase numbers you quoted at the Physics Board, for completeness? Thank you very much and happy new year! |
|
Hi @ddobrigk , happy new year 2025! Yes I confirm this PR produced an increase in AOD size as quoted at the PB. In the current configuration of forward reconstruction, it is expected to increase the size by 0.05%. Thanks a lot |
Hi @mcoquet642 , thanks, let's go ahead - I leave it up to someone with merge / approve rights to carry on. Thanks a lot! |
As discussed in physics board on 21st November, we suggest to add MFT covariances associated to global muon tracks in AODs for refit and machine learning training purposes.