Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Dec 7, 2024

Around 60-70% of the async logs are polluted by the strangeness trackers update step with negative values which is of little help.
Also the abs of the chi2 is taken afterward so the logged message is by definition ignored thus silencing it just follows this logic.

@f3sch f3sch requested review from a team and shahor02 as code owners December 7, 2024 11:46
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@f3sch
Copy link
Collaborator Author

f3sch commented Dec 16, 2024

@fmazzasc would this be fine for you?

@fmazzasc
Copy link
Contributor

Yes, it makes sense to me. Thank you!

@f3sch
Copy link
Collaborator Author

f3sch commented Dec 16, 2024

@shahor02 is it also fine for you, if so please merge?

@shahor02
Copy link
Collaborator

I cannot say that I like to accept negative chi2's quietly, but let's have it merged now. Eventually, if we don't manage to avoid bad cov.matrices, we should either redefine the cov.matrix to have chi2 positive, we should at kill the cluster.

@shahor02 shahor02 merged commit a14603d into AliceO2Group:dev Dec 16, 2024
13 checks passed
@f3sch f3sch deleted the str/quiet branch January 29, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants