Skip to content

DPL: add test for exception throwing in Variant #13735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Nov 26, 2024
Merged

DPL: add test for exception throwing in Variant #13735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Framework/Core/include/Framework/Variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ class Variant
T get() const
{
if (mType != variant_trait_v<T>) {
throw runtime_error("Mismatch between types");
throw runtime_error_f("Variant::get: Mismatch between types %d %d.", mType, variant_trait_v<T>);
}
return variant_helper<T>::get(&mStore);
}
Expand Down
12 changes: 12 additions & 0 deletions Framework/Core/test/test_Variants.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,3 +338,15 @@ TEST_CASE("VariantJSONConversionsTest")
REQUIRE(vstrings[i] == vvstra.get<std::string*>()[i]);
}
}

TEST_CASE("VariantThrowing")
{
Variant a("true");
REQUIRE_THROWS_AS(a.get<int>(), o2::framework::RuntimeErrorRef);
try {
a.get<int>();
} catch (RuntimeErrorRef& ref) {
RuntimeError& error = error_from_ref(ref);
REQUIRE(error.what == std::string("Variant::get: Mismatch between types 4 0."));
}
}