Skip to content

Protect its/mft decoder against looping hits set #13715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shahor02 wants to merge 1 commit into from
Closed

Protect its/mft decoder against looping hits set #13715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/AlpideCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,15 @@ class AlpideCoder
// are first collected in the temporary buffer
// real columnt id is col = colD + 1;
if (rightC) {
rightColHits[nRightCHits++] = row; // col = colD+1
if (nRightCHits < NRows - 1) {
rightColHits[nRightCHits++] = row;
} else {
#ifdef ALPIDE_DECODING_STAT
chipData.setError(ChipStat::RepeatingPixel);
chipData.addErrorInfo((uint64_t(colD + 1) << 16) | uint64_t(row));
#endif
return unexpectedEOF("ROW_OVERFLOW"); // abandon cable data
}
} else {
addHit(chipData, row, colD); // col = colD, left column hits are added directly to the container
}
Expand Down Expand Up @@ -353,9 +361,17 @@ class AlpideCoder
rightC = ((rowE & 0x1) ? !(addr & 0x1) : (addr & 0x1)); // true for right column / lalse for left
// the real columnt is int colE = colD + rightC;
if (rightC) { // same as above
rightColHits[nRightCHits++] = rowE;
if (nRightCHits < NRows - 1) {
rightColHits[nRightCHits++] = rowE;
} else {
#ifdef ALPIDE_DECODING_STAT
chipData.setError(ChipStat::RepeatingPixel);
chipData.addErrorInfo((uint64_t(colD + 1) << 16) | uint64_t(rowE));
#endif
return unexpectedEOF("ROW_OVERFLOW"); // abandon cable data
}
} else {
addHit(chipData, rowE, colD + rightC); // left column hits are added directly to the container
addHit(chipData, rowE, colD); // left column hits are added directly to the container
}
}
}
Expand Down
Loading