Skip to content

Conversation

@ChSonnabend
Copy link
Collaborator

This library should build and can be private linked in tasks. It serves as a basis for the future developments with the ONNX GPU build.

@ChSonnabend ChSonnabend requested a review from a team as a code owner November 18, 2024 18:47
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Please consider the following formatting changes to AliceO2Group#13709
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 9a6a9e8 at 2024-11-18 20:31:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:110:23: error: use std::make_shared instead [modernize-make-shared]
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:148:23: error: use std::make_shared instead [modernize-make-shared]
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:159:20: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:198:44: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 7251c5c at 2024-11-19 11:30:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:110:23: error: use std::make_shared instead [modernize-make-shared]
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:148:23: error: use std::make_shared instead [modernize-make-shared]
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:159:20: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:198:44: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for d0f4dd8 at 2024-11-19 21:07:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:148:59: error: expected ')' before '{' token
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:148:28: error: no matching function for call to 'std::shared_ptr<Ort::Session>::reset(<unresolved overloaded function type>)'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/shared_ptr_base.h:1431:15: error: no type named 'type' in 'struct std::enable_if<false, void>'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 7859ab2 at 2024-11-19 21:26:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13709-slc8_x86-64/0/Common/ML/src/ort_interface.cxx:148:28: error: no matching function for call to 'std::shared_ptr<Ort::Session>::reset(std::shared_ptr<Ort::Session>)'
ninja: build stopped: subcommand failed.

Full log here.

@ChSonnabend
Copy link
Collaborator Author

The build failures are independent of this PR. Can we merge as it is? (@davidrohr )

Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, we use CamelCase names for O2 header files. Can you rename those in your next update?

@ktf ktf merged commit 00c0257 into AliceO2Group:dev Nov 22, 2024
11 of 14 checks passed
@ChSonnabend ChSonnabend deleted the onnxruntime-cpu branch April 25, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants