Skip to content

Conversation

@sawenzel
Copy link
Collaborator

Developments to allow treatment/inclusion of additional orbits before each timeframe start:

  • A new option --earlyOrbits x will prepend x orbits with collisions before the firstOrbit asked
  • It will also do the same in each individual timeframe collision context extracted from the global context
  • Collisions falling within the 'earlyOrbit' range are always kept and not filtered out based on a maximal count filter

Some cleanup.

Some restructuring/simplification of DigitizationContext:

  • less internal state
  • timeframe boundary indices are generalized from (start, end) --> (start, end, previous) where previous is the index from which on this timeframe can still be influenced with an earlyOrbit criterion

Developments to allow treatment/inclusion of additional orbits
before each timeframe start:

- A new option `--earlyOrbits x` will prepend x orbits with collisions
  before the firstOrbit asked
- It will also do the same in each individual timeframe collision context extracted
  from the global context
- Collisions falling within the 'earlyOrbit' range are always kept and not
  filtered out based on a maximal count filter

Some cleanup.

Some restructuring/simplification of DigitizationContext:

- less internal state
- timeframe boundary indices are generalized from (start, end) --> (start, end, previous)
  where previous is the index from which on this timeframe can still be influenced with
  an earlyOrbit criterion
@sawenzel sawenzel requested a review from shahor02 as a code owner November 15, 2024 12:26
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@sawenzel sawenzel merged commit 9fa6915 into AliceO2Group:dev Nov 15, 2024
7 checks passed
@alcaliva alcaliva added the async-2024-pp-apass1 Request porting to async-2024-pp-apass1 label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2024-pp-apass1 Request porting to async-2024-pp-apass1

Development

Successfully merging this pull request may close these issues.

2 participants