Skip to content

DPL: drop need for has_root_setowner #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Nov 8, 2024
Merged

DPL: drop need for has_root_setowner #13667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Framework/Core/include/Framework/DataRefUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ struct DataRefUtils {
// object only depends on the state at serialization of the original object. However,
// all objects created during deserialization are new and must be owned by the collection
// to avoid memory leak. So we call SetOwner if it is available for the type.
if constexpr (has_root_setowner<T>::value) {
if constexpr (requires(T t) { t.SetOwner(true); }) {
result->SetOwner(true);
}
});
Expand Down Expand Up @@ -159,7 +159,7 @@ struct DataRefUtils {
throw runtime_error_f("Unable to extract class %s", cl == nullptr ? "<name not available>" : cl->GetName());
}
// workaround for ROOT feature, see above
if constexpr (has_root_setowner<T>::value) {
if constexpr (requires(T t) { t.SetOwner(true); }) {
result->SetOwner(true);
}
});
Expand Down
17 changes: 0 additions & 17 deletions Framework/Core/include/Framework/TypeTraits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,22 +147,5 @@ class has_root_dictionary<T, typename std::enable_if<is_container<T>::value>::ty
{
};

// Detect whether a class is a ROOT class implementing SetOwner
// This member detector idiom is implemented using SFINAE idiom to look for
// a 'SetOwner()' method.
template <typename T, typename _ = void>
struct has_root_setowner : std::false_type {
};

template <typename T>
struct has_root_setowner<
T,
std::conditional_t<
false,
class_member_checker<
decltype(std::declval<T>().SetOwner(true))>,
void>> : public std::true_type {
};

} // namespace o2::framework
#endif // FRAMEWORK_TYPETRAITS_H