Skip to content

Conversation

@ddobrigk
Copy link
Contributor

@ddobrigk ddobrigk commented Aug 24, 2024

This PR adds the missing TH1L, TH2L and TH3L types to the framework. Note that THnL sparses - the more costly options, incidentally - are already defined. The 64-bit longs are especially interesting when dealing with fast simulation, a context in which a massive amount of tracks will for sure be handled.

I'm actually having some trouble compiling this as the compiler says THxLs are not defined, which is puzzling: they are defined together in TH1.h in ROOT. Maybe I am missing something else? @aalkin when you have a moment, can you help me out? (but please do not let me disturb your weekend - only whenever you manage). Many thanks!

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@github-actions
Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Sep 24, 2024
@github-actions github-actions bot closed this Sep 29, 2024
@aalkin aalkin reopened this Oct 21, 2024
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@aalkin
Copy link
Member

aalkin commented Oct 21, 2024

@ddobrigk could you also mark it as not draft, so the tests run?

@github-actions github-actions bot closed this Oct 27, 2024
@mhemmer-cern
Copy link
Contributor

Any news on this one?

@ddobrigk
Copy link
Contributor Author

Recreated (with a rebased branch) here: #14333 - let's see if we can manage to follow this up this time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants