Skip to content

Commit 28d2dc3

Browse files
committed
GPU QA: Make cluster cuts setable and adust defaults
1 parent 53be5c4 commit 28d2dc3

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

GPU/GPUTracking/Definitions/GPUSettingsList.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,9 @@ AddOption(shipToQC, bool, false, "", 0, "Do not write output files but ship hist
512512
AddOption(shipToQCAsCanvas, bool, false, "", 0, "Send TCanvases with full layout to QC instead of individual histograms")
513513
AddOption(clusterRejectionHistograms, bool, false, "", 0, "Fill histograms with cluster rejection statistics")
514514
AddOption(histMaxNClusters, uint32_t, 500000000, "", 0, "Maximum number of clusters in rejection histograms")
515+
AddOption(minNClFindable, uint32_t, 70, "", 0, "Minimum number of (weighted) MC clusters for a track to count as findable")
516+
AddOption(minNClEff, uint32_t, 10, "", 0, "Minimum number of (weighted) MC clusters for a track to contribute to all-tracks efficiency histogramm")
517+
AddOption(minNClRes, uint32_t, 40, "", 0, "Minimum number of (weighted) MC clusters for a track to contribute to resolution histogram")
515518
AddShortcut("compare", 0, "--QAinput", "Compare QA histograms", "--qa", "--QAinputHistogramsOnly")
516519
AddHelp("help", 'h')
517520
EndConfig()

GPU/GPUTracking/qa/GPUQA.cxx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,12 @@ static constexpr float PT_MAX = 20;
158158
static constexpr float ETA_MAX = 1.5;
159159
static constexpr float ETA_MAX2 = 0.9;
160160

161-
static constexpr float MIN_WEIGHT_CLS = 40;
162-
static constexpr float FINDABLE_WEIGHT_CLS = 70;
163-
164161
static constexpr bool CLUST_HIST_INT_SUM = false;
165162

166163
static constexpr const int32_t COLORCOUNT = 12;
167164

168165
static const constexpr char* EFF_TYPES[5] = {"Rec", "Clone", "Fake", "All", "RecAndClone"};
169-
static const constexpr char* FINDABLE_NAMES[2] = {"", "Findable"};
166+
static const constexpr char* FINDABLE_NAMES[2] = {"All", "Findable"};
170167
static const constexpr char* PRIM_NAMES[2] = {"Prim", "Sec"};
171168
static const constexpr char* PARAMETER_NAMES[5] = {"Y", "Z", "#Phi", "#lambda", "Relative #it{p}_{T}"};
172169
static const constexpr char* PARAMETER_NAMES_NATIVE[5] = {"Y", "Z", "sin(#Phi)", "tan(#lambda)", "q/#it{p}_{T} (curvature)"};
@@ -1185,10 +1182,10 @@ void GPUQA::RunQA(bool matchOnly, const std::vector<o2::tpc::TrackTPC>* tracksEx
11851182
if (info.primDaughters) {
11861183
continue;
11871184
}
1188-
if (mc2.nWeightCls < MIN_WEIGHT_CLS) {
1185+
if (mc2.nWeightCls < mConfig.minNClEff) {
11891186
continue;
11901187
}
1191-
int32_t findable = mc2.nWeightCls >= FINDABLE_WEIGHT_CLS;
1188+
int32_t findable = mc2.nWeightCls >= mConfig.minNClFindable;
11921189
if (info.pid < 0) {
11931190
continue;
11941191
}
@@ -1217,9 +1214,9 @@ void GPUQA::RunQA(bool matchOnly, const std::vector<o2::tpc::TrackTPC>* tracksEx
12171214
float localY = -info.x * s + info.y * c;
12181215

12191216
if (mConfig.dumpToROOT) {
1220-
static auto effdump = GPUROOTDump<TNtuple>::getNew("eff", "alpha:x:y:z:mcphi:mceta:mcpt:rec:fake:findable:prim");
1217+
static auto effdump = GPUROOTDump<TNtuple>::getNew("eff", "alpha:x:y:z:mcphi:mceta:mcpt:rec:fake:findable:prim:ncls");
12211218
float localX = info.x * c + info.y * s;
1222-
effdump.Fill(alpha, localX, localY, info.z, mcphi, mceta, mcpt, mRecTracks[iCol][i], mFakeTracks[iCol][i], findable, info.prim);
1219+
effdump.Fill(alpha, localX, localY, info.z, mcphi, mceta, mcpt, mRecTracks[iCol][i], mFakeTracks[iCol][i], findable, info.prim, mc2.nWeightCls);
12231220
}
12241221

12251222
for (int32_t j = 0; j < 4; j++) {
@@ -1304,7 +1301,7 @@ void GPUQA::RunQA(bool matchOnly, const std::vector<o2::tpc::TrackTPC>* tracksEx
13041301
if (mConfig.filterPID >= 0 && mc1.pid != mConfig.filterPID) {
13051302
continue;
13061303
}
1307-
if (mc2.nWeightCls < MIN_WEIGHT_CLS) {
1304+
if (mc2.nWeightCls < mConfig.minNClRes) {
13081305
continue;
13091306
}
13101307
if (mConfig.resPrimaries == 1 && !mc1.prim) {

0 commit comments

Comments
 (0)