Skip to content

proxy check fix #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cobrayigamer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

proxy check fix #1139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e8bb6
fix(proxies): batch proxy removal during check to prevent backend ove…
google-labs-jules[bot] Mar 17, 2026
e362908
Merge pull request #1
cobrayigamer Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 50 additions & 2 deletions src/routes/_dashboard/instance/$instance/proxies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,11 +595,30 @@ function AddButton() {
});

const abortController = new AbortController();

const failedProxies: string[] = [];
let removalPromise: Promise<void> = Promise.resolve();

const flushFailedProxies = async (force = false) => {
while (failedProxies.length >= 50 || (force && failedProxies.length > 0)) {
const chunk = failedProxies.splice(0, 50);
removalPromise = removalPromise.then(() =>
removeProxiesBatchMutation(chunk).catch(console.error),
);
await removalPromise;
}
};

const handleCompletion = async () => {
await flushFailedProxies(true);
};

const loadingData: ExternalToast = {
cancel: {
label: t("common:cancel"),
onClick: () => {
abortController.abort();
void handleCompletion();
},
},
};
Expand Down Expand Up @@ -629,6 +648,9 @@ function AddButton() {
const data = r.data;
switch (data.oneofKind) {
case "end": {
if (!abortController.signal.aborted) {
await flushFailedProxies(true);
}
toast.success(
t("proxy.checkToast.success", {
count: failed,
Expand All @@ -651,7 +673,8 @@ function AddButton() {
failed++;
const proxyToRemove = data.single.proxy;
if (proxyToRemove) {
await removeProxiesBatchMutation([proxyToRemove.address]);
failedProxies.push(proxyToRemove.address);
void flushFailedProxies(false);
}
}

Expand All @@ -666,6 +689,7 @@ function AddButton() {
});
responses.onError((e) => {
console.error(e);
void handleCompletion();
toast.error(t("proxy.checkToast.error"), {
id: toastId,
cancel: undefined,
Expand Down Expand Up @@ -862,11 +886,30 @@ function ExtraHeader(props: { table: ReactTable<ProfileProxy> }) {
.rows.map((r) => r.original);

const abortController = new AbortController();

const failedProxies: string[] = [];
let removalPromise: Promise<void> = Promise.resolve();

const flushFailedProxies = async (force = false) => {
while (failedProxies.length >= 50 || (force && failedProxies.length > 0)) {
const chunk = failedProxies.splice(0, 50);
removalPromise = removalPromise.then(() =>
removeProxiesBatchMutation(chunk).catch(console.error),
);
await removalPromise;
}
};

const handleCompletion = async () => {
await flushFailedProxies(true);
};

const loadingData: ExternalToast = {
cancel: {
label: t("common:cancel"),
onClick: () => {
abortController.abort();
void handleCompletion();
},
},
};
Expand Down Expand Up @@ -896,6 +939,9 @@ function ExtraHeader(props: { table: ReactTable<ProfileProxy> }) {
const data = r.data;
switch (data.oneofKind) {
case "end": {
if (!abortController.signal.aborted) {
await flushFailedProxies(true);
}
toast.success(
t("proxy.checkToast.success", {
count: failed,
Expand All @@ -919,7 +965,8 @@ function ExtraHeader(props: { table: ReactTable<ProfileProxy> }) {
// Remove the invalid proxy by address
const proxyToRemove = data.single.proxy;
if (proxyToRemove) {
await removeProxiesBatchMutation([proxyToRemove.address]);
failedProxies.push(proxyToRemove.address);
void flushFailedProxies(false);
}
}

Expand All @@ -934,6 +981,7 @@ function ExtraHeader(props: { table: ReactTable<ProfileProxy> }) {
});
responses.onError((e) => {
console.error(e);
void handleCompletion();
toast.error(t("proxy.checkToast.error"), {
id: toastId,
cancel: undefined,
Expand Down