Vinc #6
Open
Vinc #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexLaur
reviewed
Mar 20, 2021
Owner
AlexLaur
left a comment
AlexLaur
left a comment
There was a problem hiding this comment.
- Correct mistakes
- Try to black your code (it is very important)
| class AnalyseFondamental(object): | ||
| def __init__(self, ticker): | ||
|
|
||
| self.thread_pool = ThreadPool() |
| from utils import utils as utl | ||
| from libs.yahoo_fin import stock_info as sf | ||
| from .analyse import AnalyseData | ||
| from libs.thread_pool import ThreadPool |
app/libs/articles_widget.py
Outdated
| self.get_articles(ticker) | ||
|
|
||
| @QtCore.Slot(str) | ||
| def get_articles(self, ticker): |
Owner
There was a problem hiding this comment.
Try to keep a homogeneity. All method signals are like this: _on_event().
This will be better :
@Qtcore.Slot(str)
def _on_(specific event):
get_articles(ticker)
app/ui/article.py
Outdated
| from libs.widgets.textbrowser import Description | ||
|
|
||
|
|
||
| class Ui_Form(object): |
app/ui/main_window.py
Outdated
| from libs.favorites_widget import FavoritesWidget | ||
| from libs.articles_widget import ArticlesWidget | ||
| from libs.widgets.label import LabelTitle | ||
| from libs.financial_widgets import TableFinance |
Owner
There was a problem hiding this comment.
remove s? widget instead of widgets ?
app/ui/run.py
Outdated
| @@ -0,0 +1,6 @@ | |||
| import subprocess | |||
Owner
There was a problem hiding this comment.
Remove this file, it already exists __convert.py
|
|
||
|
|
||
| def remove_nan(data): | ||
| """ |
Owner
There was a problem hiding this comment.
Our tool is on github, try to make an english docstring
… vinc_ � Conflicts: � app/add_ons/indicators/macd.py � app/resources/style/style.qss � app/ui/main_window.py � app/utils/utils.py
# Conflicts: # app/libs/graph/graphwidget.py # app/view.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.