Conversation
#43) Bumps the actions-deps group with 1 update: [softprops/action-gh-release](https://github.com/softprops/action-gh-release). Updates `softprops/action-gh-release` from 2 to 3 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@v2...v3) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix debug disposal * Handle null `TextureData` during `GuiDialog` initialization. * Engine support for finding files on linux systems the way the game would do it wiht abstractions layers like Wine or Valve Proton * Add support for the `--useDefaultBaseline` option and improve baseline selection logic * Remove obsolete filesystem abstraction utilities for directory and file globbing. * Introduce `PetroglyphFileSystem` abstraction for cross-platform filesystem operations. * Refactor `PetroglyphXmlFileParserBase`: remove redundant `IServiceProvider` field, optimize path handling with OS-specific logic. * Add `PG.StarWarsGame.Engine.FileSystem` project to solution * Update dependencies and add reference to `PG.StarWarsGame.Engine.FileSystem` project * Refactor: Replace generic filesystem abstraction with `PetroglyphFileSystem` for consistent, cross-platform path handling across the engine. * Refactor: Simplify `NormalizePath` logic and remove unused return value * Refactor: Use `ValueStringBuilder` in `PathStartsWithDataDirectory` for performance and normalize input paths * Refactor: Replace direct filename handling with `NormalizeFileName` for consistency and re-enable particle name mismatch validation * Refactor path normalization to use PathNormalizer Replaces custom path normalization logic in PetroglyphFileSystem with PathNormalizer from AnakinRaW.CommonUtilities. Moves LinuxDirectorySeparatorNormalizeOptions to a static readonly field. Cleans up unused usings and retains legacy code as comments for reference. * Rename StringExtensions and add Enum.Parse<T> extension Renamed StringExtensions to Extensions. Added a generic Enum.Parse<T> extension method for NETFRAMEWORK builds to simplify enum parsing from strings. * Refactor AudioFileVerifier: move FriendlyName, remove Verify Moved FriendlyName override to class body and removed the Verify method implementation from AudioFileVerifier. * Add comprehensive unit tests for `PG.StarWarsGame.Engine.FileSystem` and include test project in solution * Remove unused test case for volume file names and update path handling in `FileExists` test * Optimize case-insensitive file existence check in `PetroglyphFileSystem` and add additional test cases * Update README with detailed mod verification examples for Windows and Linux * Add Linux-specific build target to release workflow * Fix mod paths in Linux instructions * revert to old impl * Add Linux-specific tests for case-insensitive file existence handling in `PetroglyphFileSystem` * Update README: include `--engine` parameter in examples and add Linux baseline creation example * update dependencies * Refactor file path handling in GetFileInfoFromMasterMeg Check filePath length before allocating ValueStringBuilder to improve efficiency. Update warning log to use filePath.ToString() for overlong paths. Reorganize normalization logic for clarity and ensure proper resource disposal. * rename method to express intent * formatting * Update path normalization for Windows-like behavior on Linux Replaced LinuxDirectorySeparatorNormalizeOptions with PGFileSystemDirectorySeparatorNormalizeOptions to ensure consistent Windows-like path handling on Linux. Updated class documentation to clarify behavior. Refactored IsDirectorySeparator to use defined separator constants for improved clarity. * documentation * Refactor path handling to use platform-specific separators ModPaths and AdditionalFallbackPath are now single string properties using the platform-specific path separator, instead of IList<string>. SettingsBuilder splits and normalizes these paths accordingly. Help texts are updated, and unit tests are added to verify correct path parsing and normalization using a mock file system. * fix reporting of missing texutres * add new algorithm to evaluate * Handle "none" GUI textures and unify repo lookups Refactored texture existence checks by introducing IsNone and GuiSpecialTextureExists helpers. Special cases for "none" textures now avoid false warnings and are consistently cached. Centralized repository lookup logic for Scanlines, ButtonMiddle, and FrameBackground types. Improved error messages by clarifying origin labeling and adjusting error context. * update sub * update verifiers * update sub * update deps * fix false positive for "none" textures * exceptions stack traces from a verifystep now are now shown instead of the unusefull pipeline trace * add an alternate wine-style file lookup algorithm * more consistent path handling * fix and test dot segements handling * update and fix wine file lookup * add linux fs path caching * spacing * search animations based on relative path instead of absolute path. * fix potential memory leaks because of undisposed VSB * implement file system strategies to find files in a case-insensitive manner * add design spec for live virtual file-exists strategy Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * window stategy is default engine for virtual stategy on windows * fix model corrupted findings are incorrectly reported if the the engine had crc collision and loaded a different file. * add implementation plan for live virtual file-exists strategy Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * remove design spec and implementation plan for live virtual file-exists strategy Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * rename to baseDirectory * conditional using * add some test gaps * update baseline --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.