ENG-74: Add getConfiguration() to airconsole-api#108
Open
marc-n-dream wants to merge 17 commits into
Open
Conversation
Signed-off-by: marc-n-dream <marc@n-dream.com>
r: restructure the event flow to use a distinct flow
r: externalize the decision on hard vs soft fail
Store configuration from the ready event and expose it via
getConfiguration(). Returns {supportedVideoFormats, transparentVideoSupported,
unityVideoSupported, graphicsQualityTier} or undefined before onReady.
Adds Jasmine tests for both present and absent configuration.
ENG-74 Task 3
…Task 6) Clarify that getConfiguration() is only available on the screen device, returns undefined on controllers, and is delivered via the ready event.
Jasmine test verifying getConfiguration() returns undefined before the onReady READY message is received — closes review finding M2.
marc-n-dream
force-pushed
the
feature/ENG-74-platform-capability-configuration
branch
from
376a6d8 to
0b59523
Compare
marc-n-dream
force-pushed
the
feature/ENG-74-platform-capability-configuration
branch
from
e863663 to
60772b7
Compare
marc-n-dream
force-pushed
the
feature/ENG-74-platform-capability-configuration
branch
from
60772b7 to
7e04959
Compare
marc-n-dream
force-pushed
the
feature/ENG-74-platform-capability-configuration
branch
4 times, most recently
from
c063ea8 to
3524426
Compare
marc-n-dream
force-pushed
the
feature/ENG-74-platform-capability-configuration
branch
from
3524426 to
0d18fd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
getConfiguration()to airconsole-api (beta/1.11.0). The method returns the platform capability configuration injected into the READY event by the appengine.Changes
beta/airconsole-1.11.0.js:onReadystoresconfigurationfrom the READY event messagegetConfiguration()method with JSDoc (screen-only note included)tests/spec/methods/spec-configuration.js: Covers the different test scenariosDependencies
Depends on platform update to receive the configuration payload in the READY event.
Testing
All existing Jasmine specs.