Fix dropdown menu width not matching button width#427
Open
keijokapp wants to merge 1 commit intoAhmedLSayed9:masterfrom
Open
Fix dropdown menu width not matching button width#427keijokapp wants to merge 1 commit intoAhmedLSayed9:masterfrom
keijokapp wants to merge 1 commit intoAhmedLSayed9:masterfrom
Conversation
Owner
We can’t go with that, it would break the menu’s open position. Check:
Can you please open an issue with a minimal sample that produces this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was updating from
2.3.9to3.0.0and noticed some extra horizontal padding around the dropdown menu. I don't think this is intentional. TheKeythat is used to calculate the position should encapsulate the entire button, including its decoration.EDIT: Wtih this change, the
widget._inputDecoration?.isDense == falsespecial case now messes things up. I'm sure why this special case is necessary.