fix: return 404 for missing rating event#799
Merged
OSEH-svg merged 1 commit intoJun 1, 2026
Merged
Conversation
|
@nanookclaw is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #571.
This updates the event rating handler so a request for a missing path event ID returns the existing
AppError::NotFoundresponse instead of falling through to database-error behavior.The handler now verifies the path
event_idafter the ticket lookup and before the ticket/event ownership check. That keeps the existing ordering for invalid ratings and missing tickets, while preserving the403response when a real event is rated with a ticket from another event.The aggregate update also uses
fetch_optionaland maps a no-row result toNotFound, so the transaction has the same behavior if the event row disappears before theUPDATE ... RETURNING *completes.Verification:
git diff --checkI also tried
cargo fmt --check,cargo check --lib, and focusedcargo test --lib ...commands. They currently fail before this change is checked because of unrelated existing compile/format issues inroutes/mod.rs,EventSocialProofResponseRedis deserialization, and an existingSearchParamstest initializer.