Remove tracked .beads metadata#32
Conversation
📝 WalkthroughWalkthroughThis PR removes "Beads" as a supported task source system across the codebase. Type definitions and schemas are narrowed to exclude the ChangesBeads Task System Removal
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request completely removes the "Beads" integration, including its configuration files, documentation references, and adapter code from the project. The reviewer noted that src/core/types.d.ts is a duplicate of src/core/types.ts and recommended deleting the redundant declaration file to prevent TypeScript compiler conflicts and reduce maintenance overhead.
| export type TaskSourceSystem = | ||
| | "beads" | ||
| | "github" | ||
| | "linear" | ||
| | "jira" | ||
| | "plain" | ||
| | string; | ||
| | (string & {}); |
There was a problem hiding this comment.
The file src/core/types.d.ts appears to be a duplicate of src/core/types.ts. Having both a .ts and a .d.ts file with identical type definitions in the same directory violates the DRY (Don't Repeat Yourself) principle, increases maintenance overhead, and can cause TypeScript compiler conflicts or resolution issues.\n\nConsider deleting src/core/types.d.ts entirely and relying solely on src/core/types.ts for type definitions, as the compiler will automatically generate the declaration files (.d.ts) during the build process.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/cli/commands/start.ts`:
- Line 16: Update the CLI option help for the source flag so it matches the
actual valid/default values: change the description for .option("-s, --source
<system>", "Task system (github, linear, jira)") to include "plain" (and
optionally "custom") and indicate that "plain" is the default; ensure the help
text of the source option and any related default handling in the start command
(where the default is set to "plain") remain consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a58a419d-7f0c-4057-a649-d994e93c8f34
📒 Files selected for processing (15)
.beads/.gitignore.beads/.local_version.beads/README.md.beads/config.yaml.beads/issues.jsonl.beads/metadata.json.gitattributesIMPLEMENTATION-PROPOSAL.mdPROPOSAL-trajectories.mdREADME.mdbiome.jsonsrc/cli/commands/start.tssrc/core/schema.tssrc/core/types.d.tssrc/core/types.ts
💤 Files with no reviewable changes (8)
- .beads/.gitignore
- .beads/config.yaml
- .beads/.local_version
- .gitattributes
- src/core/schema.ts
- .beads/metadata.json
- .beads/README.md
- biome.json
| "-s, --source <system>", | ||
| "Task system (github, linear, jira, beads)", | ||
| ) | ||
| .option("-s, --source <system>", "Task system (github, linear, jira)") |
There was a problem hiding this comment.
Help text now omits a valid/default source value.
plain is still a valid source (and defaulted at Line 45), so this option description is now misleading. Consider listing plain (and optionally “custom”) to match actual behavior.
Proposed fix
- .option("-s, --source <system>", "Task system (github, linear, jira)")
+ .option("-s, --source <system>", "Task system (github, linear, jira, plain, or custom)")📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .option("-s, --source <system>", "Task system (github, linear, jira)") | |
| .option("-s, --source <system>", "Task system (github, linear, jira, plain, or custom)") |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/cli/commands/start.ts` at line 16, Update the CLI option help for the
source flag so it matches the actual valid/default values: change the
description for .option("-s, --source <system>", "Task system (github, linear,
jira)") to include "plain" (and optionally "custom") and indicate that "plain"
is the default; ensure the help text of the source option and any related
default handling in the start command (where the default is set to "plain")
remain consistent.
24c4519 to
ec9fb16
Compare
ec9fb16 to
91c643b
Compare
Summary
Verification
Note: unrelated untracked .agents skill directories are present locally and were left out of the PR.