Skip to content

feat(telemetry): harness detection + outgoing header + install/update + SDK events (P0 of #881) #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willwashburn wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(telemetry): harness detection + outgoing header + install/update + SDK events (P0 of #881) #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9da234d
feat(telemetry): orchestrator harness detection
willwashburn May 18, 2026
2417c8e
feat(telemetry): SDK telemetry + outgoing relaycast harness header
willwashburn May 18, 2026
7fffdd9
refactor(telemetry): rename orchestrator_harness → harness
willwashburn May 18, 2026
aba6675
Merge main and address telemetry review feedback
willwashburn May 19, 2026
80957d1
style: auto-format Rust code with cargo fmt
github-actions[bot] May 19, 2026
0900137
Relax harness slug validation
willwashburn May 19, 2026
5503062
Merge remote-tracking branch 'origin/main' into chore/telemetry-p0-in…
willwashburn May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions .trajectories/completed/2026-05/traj_0z98tkaigaxg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,51 @@ All 17 steps completed in 29min.
## Chapters

### 1. Planning
*Agent: orchestrator*

_Agent: orchestrator_

### 2. Execution: lead-plan
*Agent: lead-codex*

_Agent: lead-codex_

### 3. Execution: implement-slice
*Agent: impl-codex*

_Agent: impl-codex_

### 4. Execution: review-codex-primary
*Agent: reviewer-codex-primary*

_Agent: reviewer-codex-primary_

### 5. Execution: fix-loop
*Agent: validator-codex-primary*

_Agent: validator-codex-primary_

### 6. Execution: final-review-codex-primary
*Agent: reviewer-codex-primary*

_Agent: reviewer-codex-primary_

### 7. Execution: final-fix-codex-primary
*Agent: validator-codex-primary*

_Agent: validator-codex-primary_

### 8. Execution: review-codex
*Agent: reviewer-codex*

_Agent: reviewer-codex_

### 9. Execution: fix-loop-codex
*Agent: validator-codex*

_Agent: validator-codex_

### 10. Execution: final-review-codex
*Agent: reviewer-codex*

_Agent: reviewer-codex_

### 11. Execution: final-fix-codex
*Agent: validator-codex*

_Agent: validator-codex_

### 12. Retrospective
*Agent: orchestrator*

_Agent: orchestrator_

- All 17 steps completed in 29min. (completed in 29 minutes)
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove redundant completion time statement.

The completion statement is duplicated with slightly different wording: "All 17 steps completed in 29min. (completed in 29 minutes)".

✂️ Proposed fix 
-- All 17 steps completed in 29min. (completed in 29 minutes)
+- All 17 steps completed in 29min.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- All 17 steps completed in 29min. (completed in 29 minutes)
- All 17 steps completed in 29min.
🧰 Tools
🪛 LanguageTool

[grammar] ~69-~69: Ensure spelling is correct
Context: ...hestrator_ - All 17 steps completed in 29min. (completed in 29 minutes)

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.trajectories/completed/2026-05/traj_0z98tkaigaxg.md at line 69, The
completion line currently duplicates the same info ("All 17 steps completed in
29min. (completed in 29 minutes)"); replace it with a single, non-redundant
statement such as "All 17 steps completed in 29 minutes." by removing the
parenthetical duplicate so only one clear completion sentence remains (look for
the exact string "All 17 steps completed in 29min. (completed in 29 minutes)").

2 changes: 1 addition & 1 deletion .trajectories/completed/2026-05/traj_1778873209642_c70e32ab.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,4 +213,4 @@
"commits": [],
"filesChanged": [],
"tags": []
}
}
15 changes: 10 additions & 5 deletions .trajectories/completed/2026-05/traj_1778873209642_c70e32ab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,21 @@ Updated messaging CLI tests for replies, inbox transcript rendering, history mes
## Chapters

### 1. Planning
*Agent: orchestrator*

_Agent: orchestrator_

### 2. Execution: lead-plan
*Agent: lead-claude*

_Agent: lead-claude_

### 3. Execution: implement-slice
*Agent: impl-codex*

_Agent: impl-codex_

### 4. Execution: implement-slice
*Agent: impl-codex*

_Agent: impl-codex_

### 5. Execution: review-claude
*Agent: reviewer-claude*

_Agent: reviewer-claude_
10 changes: 2 additions & 8 deletions .trajectories/completed/2026-05/traj_1778873211616_6db3b2cd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,7 @@
"reason": "Legacy STEP_COMPLETE marker observed",
"evidence": {
"summary": "5 signal(s), 1 relevant channel post(s), 6 file change(s)",
"signals": [
"implement-slice",
"COMPLETE",
">7u",
"0",
"COMPLETE"
],
"signals": ["implement-slice", "COMPLETE", ">7u", "0", "COMPLETE"],
"channelPosts": [
"**[implement-slice] Output:**\n```\n └ .claude/rules/docs-sync.md | 39 ++++++++++++++++++------------\n .trajectories/index.json | 59 ++++++++++++++++++++++"
],
Expand Down Expand Up @@ -257,4 +251,4 @@
"commits": [],
"filesChanged": [],
"tags": []
}
}
18 changes: 12 additions & 6 deletions .trajectories/completed/2026-05/traj_1778873211616_6db3b2cd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,32 @@ Updated docs/reference-cli.md with curated agent-relay messaging command referen
## Key Decisions

### Updated curated docs/reference-cli.md instead of creating docs cli mirrors

- **Chose:** Updated curated docs/reference-cli.md instead of creating docs cli mirrors
- **Reasoning:** The branch docs-sync rule says web MDX is canonical and top-level docs/*.md are curated, so this slice documents duplicated CLI behavior in the existing curated CLI reference.
- **Reasoning:** The branch docs-sync rule says web MDX is canonical and top-level docs/\*.md are curated, so this slice documents duplicated CLI behavior in the existing curated CLI reference.

---

## Chapters

### 1. Planning
*Agent: orchestrator*

_Agent: orchestrator_

### 2. Execution: lead-plan
*Agent: lead-claude*

_Agent: lead-claude_

### 3. Execution: implement-slice
*Agent: impl-codex*

_Agent: impl-codex_

### 4. Execution: review-claude
*Agent: reviewer-claude*

_Agent: reviewer-claude_

### 5. Execution: fix-loop
*Agent: validator-claude*

_Agent: validator-claude_

- Updated curated docs/reference-cli.md instead of creating docs cli mirrors: Updated curated docs/reference-cli.md instead of creating docs cli mirrors
36 changes: 24 additions & 12 deletions .trajectories/completed/2026-05/traj_5q8i0iz4klpo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,51 @@ All 17 steps completed in 29min.
## Chapters

### 1. Planning
*Agent: orchestrator*

_Agent: orchestrator_

### 2. Execution: lead-plan
*Agent: lead-codex*

_Agent: lead-codex_

### 3. Execution: implement-slice
*Agent: impl-codex*

_Agent: impl-codex_

### 4. Execution: review-codex-primary
*Agent: reviewer-codex-primary*

_Agent: reviewer-codex-primary_

### 5. Execution: fix-loop
*Agent: validator-codex-primary*

_Agent: validator-codex-primary_

### 6. Execution: final-review-codex-primary
*Agent: reviewer-codex-primary*

_Agent: reviewer-codex-primary_

### 7. Execution: final-fix-codex-primary
*Agent: validator-codex-primary*

_Agent: validator-codex-primary_

### 8. Execution: review-codex
*Agent: reviewer-codex*

_Agent: reviewer-codex_

### 9. Execution: fix-loop-codex
*Agent: validator-codex*

_Agent: validator-codex_

### 10. Execution: final-review-codex
*Agent: reviewer-codex*

_Agent: reviewer-codex_

### 11. Execution: final-fix-codex
*Agent: validator-codex*

_Agent: validator-codex_

### 12. Retrospective
*Agent: orchestrator*

_Agent: orchestrator_

- All 17 steps completed in 29min. (completed in 29 minutes)
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove redundant completion time statement.

The completion statement is duplicated with slightly different wording: "All 17 steps completed in 29min. (completed in 29 minutes)".

✂️ Proposed fix 
-- All 17 steps completed in 29min. (completed in 29 minutes)
+- All 17 steps completed in 29min.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- All 17 steps completed in 29min. (completed in 29 minutes)
- All 17 steps completed in 29min.
🧰 Tools
🪛 LanguageTool

[grammar] ~69-~69: Ensure spelling is correct
Context: ...hestrator_ - All 17 steps completed in 29min. (completed in 29 minutes)

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.trajectories/completed/2026-05/traj_5q8i0iz4klpo.md at line 69, Remove the
duplicated completion time phrase in the markdown line that currently reads "All
17 steps completed in 29min. (completed in 29 minutes)"; edit the text in the
trajectory file so it contains a single, consistent completion statement (e.g.,
"All 17 steps completed in 29 minutes.") by removing the redundant parenthetical
or the shorter "29min." form.

36 changes: 24 additions & 12 deletions .trajectories/completed/2026-05/traj_8ljgydz61do5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,51 @@ All 17 steps completed in 35min.
## Chapters

### 1. Planning
*Agent: orchestrator*

_Agent: orchestrator_

### 2. Execution: lead-plan
*Agent: lead-codex*

_Agent: lead-codex_

### 3. Execution: implement-slice
*Agent: impl-codex*

_Agent: impl-codex_

### 4. Execution: review-codex-primary
*Agent: reviewer-codex-primary*

_Agent: reviewer-codex-primary_

### 5. Execution: fix-loop
*Agent: validator-codex-primary*

_Agent: validator-codex-primary_

### 6. Execution: final-review-codex-primary
*Agent: reviewer-codex-primary*

_Agent: reviewer-codex-primary_

### 7. Execution: final-fix-codex-primary
*Agent: validator-codex-primary*

_Agent: validator-codex-primary_

### 8. Execution: review-codex
*Agent: reviewer-codex*

_Agent: reviewer-codex_

### 9. Execution: fix-loop-codex
*Agent: validator-codex*

_Agent: validator-codex_

### 10. Execution: final-review-codex
*Agent: reviewer-codex*

_Agent: reviewer-codex_

### 11. Execution: final-fix-codex
*Agent: validator-codex*

_Agent: validator-codex_

### 12. Retrospective
*Agent: orchestrator*

_Agent: orchestrator_

- All 17 steps completed in 35min. (completed in 35 minutes)
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove redundant completion time statement.

The completion statement is duplicated with slightly different wording: "All 17 steps completed in 35min. (completed in 35 minutes)".

✂️ Proposed fix 
-- All 17 steps completed in 35min. (completed in 35 minutes)
+- All 17 steps completed in 35min.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- All 17 steps completed in 35min. (completed in 35 minutes)
- All 17 steps completed in 35min.
🧰 Tools
🪛 LanguageTool

[grammar] ~69-~69: Ensure spelling is correct
Context: ...hestrator_ - All 17 steps completed in 35min. (completed in 35 minutes)

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.trajectories/completed/2026-05/traj_8ljgydz61do5.md at line 69, Remove the
duplicated completion phrase by keeping a single clear sentence — replace "All
17 steps completed in 35min. (completed in 35 minutes)" with one consistent
line, e.g., "All 17 steps completed in 35 minutes."; remove the redundant
fragment (either "All 17 steps completed in 35min." or "(completed in 35
minutes)") so only one completion statement remains.

53 changes: 53 additions & 0 deletions .trajectories/completed/2026-05/traj_citl6rhje2sc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
"id": "traj_citl6rhje2sc",
"version": 1,
"task": {
"title": "Review and fix PR 888 comments and conflicts"
},
"status": "completed",
"startedAt": "2026-05-19T16:54:14.672Z",
"completedAt": "2026-05-19T16:54:23.471Z",
"agents": [
{
"name": "default",
"role": "lead",
"joinedAt": "2026-05-19T16:54:18.777Z"
}
],
"chapters": [
{
"id": "chap_g3oh7vnb88n4",
"title": "Work",
"agentName": "default",
"startedAt": "2026-05-19T16:54:18.777Z",
"endedAt": "2026-05-19T16:54:23.471Z",
"events": [
{
"ts": 1779209658778,
"type": "decision",
"content": "Kept the telemetry event contract on orchestrator_harness: Kept the telemetry event contract on orchestrator_harness",
"raw": {
"question": "Kept the telemetry event contract on orchestrator_harness",
"chosen": "Kept the telemetry event contract on orchestrator_harness",
"alternatives": [],
"reasoning": "Review feedback identified harness as a contract-breaking rename; retaining orchestrator_harness keeps existing PostHog dashboards and SDK/CLI/broker emitters aligned."
},
"significance": "high"
}
]
}
],
"retrospective": {
"summary": "Merged main into PR 888, resolved the SDK client conflict, addressed telemetry/harness review comments, and validated targeted TypeScript and Rust tests.",
"approach": "Standard approach",
"confidence": 0.86
},
"commits": [],
"filesChanged": [],
"projectId": "/Users/will/Projects/AgentWorkforce/relay/.claude/worktrees/agent-a90562b7ed038f1a0",
"tags": [],
"_trace": {
"startRef": "7fffdd98da650602a4278a86a9ec4b2f6e71641c",
"endRef": "7fffdd98da650602a4278a86a9ec4b2f6e71641c"
}
}
33 changes: 33 additions & 0 deletions .trajectories/completed/2026-05/traj_citl6rhje2sc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Trajectory: Review and fix PR 888 comments and conflicts

> **Status:** ✅ Completed
> **Confidence:** 86%
> **Started:** May 19, 2026 at 12:54 PM
> **Completed:** May 19, 2026 at 12:54 PM

---

## Summary

Merged main into PR 888, resolved the SDK client conflict, addressed telemetry/harness review comments, and validated targeted TypeScript and Rust tests.

**Approach:** Standard approach

---

## Key Decisions

### Kept the telemetry event contract on orchestrator_harness

- **Chose:** Kept the telemetry event contract on orchestrator_harness
- **Reasoning:** Review feedback identified harness as a contract-breaking rename; retaining orchestrator_harness keeps existing PostHog dashboards and SDK/CLI/broker emitters aligned.

---

## Chapters

### 1. Work

_Agent: default_

- Kept the telemetry event contract on orchestrator_harness: Kept the telemetry event contract on orchestrator_harness
Loading
Loading