chore: remove migrated packages and consolidate shared into utils#1014
Conversation
Remove packages extracted to standalone repos or other monorepos: - acp-bridge → agent-relay-acp-bridge - openclaw → agent-relay-openclaw - credential-proxy → credential-proxy - personas → agent-relay-personas - github-primitive, slack-primitive, browser-primitive → relayflows - events, agent, memory → proactive - hooks, gateway, trajectory (dropped entirely) Move packages/shared (cli-registry.yaml, codegen-ts.mjs, codegen-py.mjs) into packages/utils and update codegen:models scripts accordingly. Update sdk: remove /github and /slack subpath exports, drop github-primitive and slack-primitive deps. Update cli: drop hooks/memory/trajectory deps and remove their re-exports from the public index. Remove acp-bridge from the core-maintenance uninstall list. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedToo many files! This PR contains 220 files, which is 70 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (220)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce8c0c3f98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,51 +0,0 @@ | |||
| { | |||
| "name": "@agent-relay/hooks", | |||
There was a problem hiding this comment.
Deleting @agent-relay/hooks leaves the package-validation workflow still importing it in .github/workflows/package-validation.yml lines 156-160. On any validation run after this change, that import cannot resolve because the workspace/package no longer exists, so the workflow fails before the remaining package smoke tests; please remove or replace the stale import with the package deletion.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in a5fdede — removed @agent-relay/hooks from the import test list in package-validation.yml.
| @@ -1,59 +0,0 @@ | |||
| { | |||
| "name": "@agent-relay/acp-bridge", | |||
There was a problem hiding this comment.
Removing packages/acp-bridge leaves the release workflow's build-acp-standalone job still compiling ./packages/acp-bridge/dist/cli.js in .github/workflows/publish.yml lines 365-380. For package=all or package=main releases, this path no longer exists after npm run build, so the publish workflow fails before uploading release assets; please remove or retarget that job together with this package removal.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in the CI workflow cleanup commit — build-acp-standalone job and its downstream verify-acp-* jobs have been removed from publish.yml.
| @@ -1,43 +0,0 @@ | |||
| { | |||
| "name": "@agent-relay/github-primitive", | |||
There was a problem hiding this comment.
The publish workflow's SDK smoke step still runs cd packages/github-primitive && npm pack and the same for packages/slack-primitive in .github/workflows/publish.yml lines 683-688, but both directories are removed here and the SDK dependencies were dropped. Any SDK release smoke run will exit on the missing cd before it can install the tarballs; please update that tarball list with the dependency removal.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in the CI workflow cleanup commit — github-primitive and slack-primitive pack steps and tarball references have been removed from the smoke test in publish.yml.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 195 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
|
Reviewed PR #1014 and fixed the push-back hardening gap I found. Changes made:
Verification:
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e lockfile Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… memory Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
crypto.randomUUID() via the Web Crypto global requires --experimental-global-webcrypto in Node 18 and is only unconditionally available from Node 21. Import randomUUID from node:crypto to support the Node >=18 engine range. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The Publish Fresh Install Build job always runs without turbo cache. With 13 packages building concurrently on a 7GB runner (immediately after a Rust build), tsc processes collectively exceed available RAM. Split Rust and TS builds into separate steps and cap turbo concurrency at 2 so at most 2 tsc processes run simultaneously. Root cause: tsconfig.json is a turbo globalDependency, so changing it invalidates all cached build outputs and forces a full cold build. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment |
Summary
acp-bridge,openclaw,credential-proxy,personas,github-primitive,slack-primitive,browser-primitive,events,agent,memory,hooks,gateway,trajectorypackages/shared(cli-registry.yaml,codegen-ts.mjs,codegen-py.mjs) intopackages/utils; updatecodegen:modelsscripts accordinglyhooks,memory,trajectorydeps and their re-exports frompackages/cligithub-primitive,slack-primitive,credential-proxydeps and the/github+/slacksubpath exports frompackages/sdkacp-bridgefrom thecore-maintenanceuninstall listbuild:memory,build:trajectory,build:hooksroot scriptsbuild-acp-standaloneandbuild-openclaw-binary.ymlCI jobs; drop migrated packages from smoke tests and publish matrixNew package homes
acp-bridgeopenclawcredential-proxypersonasgithub-primitive,slack-primitive,browser-primitiveevents,agent,memoryTest plan
npm run build:coresucceedsnpm run typecheckpassesnpm run testpasses🤖 Generated with Claude Code