fix: add None checks before accessing __dict__ on optional tool fields#1305
Open
guoyangzhen wants to merge 1 commit intoAgentOps-AI:mainfrom
Open
fix: add None checks before accessing __dict__ on optional tool fields#1305guoyangzhen wants to merge 1 commit intoAgentOps-AI:mainfrom
guoyangzhen wants to merge 1 commit intoAgentOps-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using OpenAI Agents SDK with file search or web search tools, on_span_end raises:
The root cause: hasattr() returns True even when the attribute exists but is None. Then accessing .dict on None crashes.
Affected locations in response.py:
Fix
Add is not None checks alongside hasattr():