Skip to content

[balanceplatform] Code generation: update services and models#385

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/balanceplatform
Open

[balanceplatform] Code generation: update services and models#385
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner May 19, 2026 12:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BalancePlatform service by moving sweep-related methods from BalanceAccountsApi to a new CustomPayoutSchedulesSweepsApi class and introducing a ManagedPayoutSchedulesApi class. A critical issue was identified where existing tests in spec/balance_platform_spec.rb were not updated to reflect these changes, which will lead to test failures when calling the moved methods.

I am having trouble creating individual review comments. Click here to see my feedback.

lib/adyen/services/balancePlatform/balance_accounts_api.rb (23-45)

critical

The sweep-related methods have been moved from BalanceAccountsApi to the new CustomPayoutSchedulesSweepsApi class, but the tests in spec/balance_platform_spec.rb have not been updated. This will cause existing tests to fail. For example, the test 'makes a balance_account/sweeps DELETE call' still calls balance_accounts_api.delete_sweep. Please update the tests to call these methods from the new custom_payout_schedules_sweeps_api.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from 5d23244 to a79c5d4 Compare May 19, 2026 14:55
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 2 times, most recently from 3eb8bc0 to fae260c Compare May 28, 2026 09:01
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from fae260c to 7c8ba88 Compare June 1, 2026 09:44
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant