[transfers] Code generation: update services and models#485
[transfers] Code generation: update services and models#485AdyenAutomationBot wants to merge 1 commit into
Conversation
f6f2a4b to
82ec2c8
Compare
|
There was a problem hiding this comment.
Code Review
This pull request introduces the new CashOutApi service, renames CapitalApi to CapitalDeprecatedApi, and adds an SDK generation log. The review feedback highlights that renaming CapitalApi and removing the capital_api attribute from AdyenTransfersApi are breaking changes for existing integrations. It is recommended to maintain backwards compatibility by keeping CapitalApi as an alias in both the module imports and the AdyenTransfersApi class.
| @@ -1,5 +1,6 @@ | |||
| from ..base import AdyenServiceBase | |||
| from .capital_api import CapitalApi | |||
| from .capital_deprecated_api import CapitalDeprecatedApi | |||
There was a problem hiding this comment.
Renaming CapitalApi to CapitalDeprecatedApi is a breaking change for existing integrations that import CapitalApi directly from this module. To maintain backwards compatibility, consider importing CapitalDeprecatedApi as CapitalApi as well.
| from .capital_deprecated_api import CapitalDeprecatedApi | |
| from .capital_deprecated_api import CapitalDeprecatedApi, CapitalDeprecatedApi as CapitalApi |
| self.capital_deprecated_api = CapitalDeprecatedApi(client=client) | ||
| self.cash_out_api = CashOutApi(client=client) |
There was a problem hiding this comment.
Removing the capital_api attribute from AdyenTransfersApi will break existing code that accesses this service via adyen.transfers.capital_api. To prevent breaking changes, we should keep capital_api as an alias pointing to capital_deprecated_api.
| self.capital_deprecated_api = CapitalDeprecatedApi(client=client) | |
| self.cash_out_api = CashOutApi(client=client) | |
| self.capital_deprecated_api = CapitalDeprecatedApi(client=client) | |
| self.capital_api = self.capital_deprecated_api | |
| self.cash_out_api = CashOutApi(client=client) |
jeandersonbc
left a comment
There was a problem hiding this comment.
I'm a bit surprised that this didn't break in any pipeline run - perhaps a hint that we lack coverage for that. In any case, we must update the code generation to indicate on PyDocs that API is deprecated and not embed this info into the package naming.



This PR contains the automated changes for the
transfersservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.