Skip to content

[transfers] Code generation: update services and models#485

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transfers
Open

[transfers] Code generation: update services and models#485
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transfers

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the transfers service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner June 1, 2026 09:45
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch from f6f2a4b to 82ec2c8 Compare June 1, 2026 09:45
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new CashOutApi service, renames CapitalApi to CapitalDeprecatedApi, and adds an SDK generation log. The review feedback highlights that renaming CapitalApi and removing the capital_api attribute from AdyenTransfersApi are breaking changes for existing integrations. It is recommended to maintain backwards compatibility by keeping CapitalApi as an alias in both the module imports and the AdyenTransfersApi class.

@@ -1,5 +1,6 @@
from ..base import AdyenServiceBase
from .capital_api import CapitalApi
from .capital_deprecated_api import CapitalDeprecatedApi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Renaming CapitalApi to CapitalDeprecatedApi is a breaking change for existing integrations that import CapitalApi directly from this module. To maintain backwards compatibility, consider importing CapitalDeprecatedApi as CapitalApi as well.

Suggested change
from .capital_deprecated_api import CapitalDeprecatedApi
from .capital_deprecated_api import CapitalDeprecatedApi, CapitalDeprecatedApi as CapitalApi

Comment on lines +17 to +18
self.capital_deprecated_api = CapitalDeprecatedApi(client=client)
self.cash_out_api = CashOutApi(client=client)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing the capital_api attribute from AdyenTransfersApi will break existing code that accesses this service via adyen.transfers.capital_api. To prevent breaking changes, we should keep capital_api as an alias pointing to capital_deprecated_api.

Suggested change
self.capital_deprecated_api = CapitalDeprecatedApi(client=client)
self.cash_out_api = CashOutApi(client=client)
self.capital_deprecated_api = CapitalDeprecatedApi(client=client)
self.capital_api = self.capital_deprecated_api
self.cash_out_api = CashOutApi(client=client)

Copy link
Copy Markdown
Contributor

@jeandersonbc jeandersonbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that this didn't break in any pipeline run - perhaps a hint that we lack coverage for that. In any case, we must update the code generation to indicate on PyDocs that API is deprecated and not embed this info into the package naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants