[payment] Code generation: update services and models (javadoc only)#1911
[payment] Code generation: update services and models (javadoc only)#1911
Conversation
AdyenAutomationBot
force-pushed
the
sdk-automation/payment
branch
from
f882309 to
5436cf0
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SDK generation log and expands the Javadoc for the shopperLocale property in the PaymentRequest, PaymentRequest3d, and PaymentRequest3ds2 classes to include ISO standard references and examples. Feedback suggests simplifying these Javadoc entries to improve readability and reduce redundancy, as the same detailed description is currently repeated for the method, parameter, and return value.
| * The language for the payment. The value combines the two-letter [ISO | ||
| * 639-1](https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes) language code with the | ||
| * [ISO 3166-1 alpha-2](https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes) country | ||
| * code. For example, **nl-NL**. When using Drop-in/Components, the specified language appears if | ||
| * your front-end global configuration does not set the `locale`. |
There was a problem hiding this comment.
The Javadoc for shopperLocale is quite long and contains multiple links. Consider simplifying the description while keeping the essential information to improve readability.
| * The language for the payment. The value combines the two-letter [ISO | ||
| * 639-1](https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes) language code with the | ||
| * [ISO 3166-1 alpha-2](https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes) country | ||
| * code. For example, **nl-NL**. When using Drop-in/Components, the specified language appears if | ||
| * your front-end global configuration does not set the `locale`. |
There was a problem hiding this comment.
The Javadoc for shopperLocale is quite long and contains multiple links. Consider simplifying the description while keeping the essential information to improve readability.
| * The language for the payment. The value combines the two-letter [ISO | ||
| * 639-1](https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes) language code with the | ||
| * [ISO 3166-1 alpha-2](https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes) country | ||
| * code. For example, **nl-NL**. When using Drop-in/Components, the specified language appears if | ||
| * your front-end global configuration does not set the `locale`. |
There was a problem hiding this comment.
The Javadoc for shopperLocale is quite long and contains multiple links. Consider simplifying the description while keeping the essential information to improve readability.
gcatanese
changed the title
2 participants
This PR contains the automated changes for the
paymentservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.