Fix linter warnings in set-up.md#567
Open
pru55e11 wants to merge 1 commit into
Open
Conversation
Address five pre-existing linter warnings on src/pages/get_started/app_builder_get_started/set-up.md surfaced by the lint job: - Shorten the frontmatter description from 192 chars to 117 chars (under the 160-char guidance). - Replace the redirecting `solutionpartners.adobe.com/home.html` URL with its final `partners.adobe.com/digitalexperience/` destination. - Replace three dead/blocked `npmjs.com/package/inquirer` URLs (including anchor fragments that no longer exist on the new Inquirer monorepo) with the live `github.com/SBoudrias/Inquirer.js` repo URL.
Contributor
🔍 Linter ReportClick to expand full reportThis comment was automatically generated by the linter bot. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of five pre-existing linter warnings on
src/pages/get_started/app_builder_get_started/set-up.mdthat were surfaced in the lint report on #566. None of them are fatal (the lint check currently passes), but they show up as noise on every PR that touches this directory.descriptionfrom 192 chars to 117 chars to satisfy thecheck-frontmatterrule (under 160).https://solutionpartners.adobe.com/home.htmllink with its final destinationhttps://partners.adobe.com/digitalexperience/to satisfy theno-dead-urlsredirect rule.https://www.npmjs.com/package/inquirerlinks (one bare, two with#support-os-terminals/#known-issuesanchors) withhttps://github.com/SBoudrias/Inquirer.js. The npm URLs are flagged as dead by the linter; the GitHub repo is the canonical home now and the anchors on the npm page no longer exist on the new monorepo README.Why not also fix the other warnings?
The lint report on #566 surfaces ~428 warnings repo-wide, but the vast majority are unrelated to set-up.md and would belong in separate, file-scoped cleanups. I kept this PR tight to
set-up.mdso it can be reviewed and landed quickly.Test plan
src/pages/get_started/app_builder_get_started/set-up.mdin the posted linter report.set-up.mdpage and visually verify the Inquirer documentation link resolves correctly and the Solution Partner Portal link still lands on the right page.