Video Store API -- Lindsey and Ashley#11
Open
catchingash wants to merge 208 commits intoAda-Developers-Academy:anw+lr/masterfrom
Open
Video Store API -- Lindsey and Ashley#11catchingash wants to merge 208 commits intoAda-Developers-Academy:anw+lr/masterfrom
catchingash wants to merge 208 commits intoAda-Developers-Academy:anw+lr/masterfrom
Conversation
We decided on endpoints / query options.
Includes commented out code that would be awesome if we could figure out how to fix the bug, but not high priority right now.
Still a WIP until we get the other data fields as well (like dates).
Moved Database tests --> Movie tests where applicable.
Small refactors.
…deoStoreAPI into lr/rentals
- removes unnecessary test code (`this.test`) - changes double quotes to single just 'cause - adds `done` to beforeEach so that the object is for sure created before the tests are run (shouldn't be an issue anyway since it's not an asynchronous action, but just to be sure)
Adds Database#all + movies#all test.
…nd the movie_title in the request body
changed n and p in the statements for #sortBy to ?
Update rental/lr
…ed a test for #numAvail in movie specific functions
Num avail/lr
…der the results in #customersPast
…deoStoreAPI into movies_title_customers/lr
…deoStoreAPI into anw/rentals_controller/anw+lr
movies/:title/customers endpoint with tests
…deoStoreAPI into anw/rentals_controller/anw+lr
…By function to get all the data needed for the results
Fix movie title/lr
Renamed from movies to rentals because it seemed more appropriate, since it's returning rentals / rental info, rather than movie objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I completed this with @lindseyreno.
We are very happy with our models, controllers, and test coverage. We had a lot of fun learning Node/Express, and are proud of our comfort levels with callbacks and scope.