Emilce Sanchez - Solar System - Octos

[emilcecarlisa]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What was the purpose of the initialize method in your class?	It creates a new instance of class SolarSystem and Planet
Describe an instance variable you used and what you used it for.	I used the instance variable @planets to create an array of planets.
Describe what the difference would be if your SolarSystem used an Array vs a Hash.	In the hash I was able to call the planet using key, value syntax but with an array I used a method that called the instance variables (like (planet) name) in a new object planet.
Do you feel like you used consistent formatting throughout your code?	Yes

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Readable code with consistent indentation.	Check
Primary Requirements
Created Custom Solar System Class with initialize, add planet & list planets methods, without using puts.	You have method doing puts and gets.chomp in your code, see my note in your code. This is a minor problem where you're mixing what the class is doing.
Planet Class Created	Check
Created a collection of Planet objects as an instance variable in SolarSystem.	Check
Accessor methods created	Check, but you made them attr_accessor instead of attr_reader.
Method created to return the Planet's attributes and not use puts	Check
Created a user interface to interact with the SolarSystem including adding a planet and viewing a planet's details	Check, but your interface is a bit cryptic and not intuitive
Additional Notes	Nicely done, you hit all the requirements. I left minor notes in your code. Well done!

[CheezItMan]

You're requiring gems, which is new. neat!

[CheezItMan]

A couple of issues,

1. You are making these with attr_accessor which means a user could directly change the instance variables. Instead I would recommend making them attr_reader unless you really want to give a user the ability to reassign the instance variables.
2. Why are planet_details, choose_planet planet_list and add_planet here? They're methods not instance variables.

[CheezItMan]

This method is part of SolarSystem and it's mixing concerns a bit. It's part of SolarSystem and also dealing with the user and keyboard input and puts. This is a mix of roles. Generally a class should deal with one concept. In this case SolarSystem should focus on being a collection of planets and operations you can do on a SolarSystem. So Solar System does it's thing and methods in the main program can deal with the user.

BTW this is a very minor thing in this project