sai's recipe finder

[ssamant]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I used postman and read the docs
Describe your API Wrapper. How did you decide on the methods you created?	I have a self method that returns the first 100 recipes of a query and a self method that returns one recipe based on the recipe id. I decided on these based on the requirements (and i limited the results so they wouldn't be overwhelming.
Describe an edge case or failure case test you wrote for your API Wrapper.	testing what gets returned if someone enters an empty string
Explain how VCR aids in testing an API.	VCR allows you to test the API without having to make multiple requests. It "records" the API request (in a yml?) so that it can be used for multiple tests
What is the Heroku URL of your deployed application?	https://sai-recipes.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Foundations is still really unclear to me.

[kariabancroft]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Looks good
Comprehension questions	Yes
General
Rails fundamentals (RESTful routing, use of named paths)	Good
Semantic HTML	Looks good
Errors are reported to the user	Yes! Nice job with this
API Wrapper to handle the API requests	Yes. Memoizing constants into local variables isn't going to buy you any optimization.
Controller testing	Yes. Nice job with testing the controller as well as the API wrapper.
Styling
Foundation Styling for responsive layout	Lol yes! I love your theme. I like the recipe labels.
Search View	Good - might be nice to have this on a nav bar or something so it's a bit easier to find
List View	Good - i like the way you set the alt text on the imgs
Show View which opens in a new tab	Yes
API Features
The App attributes Edaman	Yes although it seems like there is some issue with the image displaying
The VCR casettes do not contain the API key	Check
Overall	Nice job with the recent searches feature. You covered the major learning goals of this assignment.