Mary Morrison TaskListRails - OAuth #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w in controller, populated new.html.erb with labels and data types and submit.
…lso populated create.html.erb, but that isn't really relevant
…t and update, populated edit.html.erb page
…'s for edit, delete, and create new task in index.html.erb
…because that is the right way...
… set if complete button is clicked. Time doesn't reset if button is unclicked.
…ate, login, show, and logout. Also, private application controller actions logged_in? and current_user
…ods: current_user and require_login. To session controller: added skip_before_action of require_login for create action to avoid a million redirects
…examples until now, it finally works. UGHHH. Still need testing
…es not belong to them.
…e3::ConstraintException etc. Using yaml files would probably help, but I am tired, this is already late for a PR, and as far as I know, everything else it working. Fin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of this were very frustrating and difficult for me. I kept getting localhost timeouts because of a redirect loop and I wanted to pull my hair out. Also, my unit tests are all giving errors (something to the tune of: ActiveRecord::StatementInvalid: ActiveRecord::StatementInvalid: SQLite3::ConstraintException: NOT NULL constraint failed: users.uid: INSERT INTO "users" ("created_at", "updated_at", "id") VALUES ('2016-10-26 05:45:37', '2016-10-26 05:45:37', 980190962)), but I am very tired and this assignment is already late, so I'm ignoring it. As far as I know, everything else is functioning properly. But of course, you can't really know anything is working properly unless you test it. I think this would have been much easier to do had I not been working on Betsy in between. I did the first wave without incident and finished during the first hour of class, but coming back to it a week later to do the other 2 waves did not work very well for me. I should have squeezed in more time during the school week when it was still fresh in my mind, instead of dedicating all class and HW time to Betsy. I've been working on controller testing for Betsy, so I feel confident in that regard, and tomorrow I plan on doing the Betsy unit testing. So hopefully that will go better than this unit testing. drops the mic