Water - Sophia#43
Open
SoCodeDo wants to merge 10 commits into
Open
Conversation
CheezItMan
reviewed
Nov 29, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Thanks for getting in what you did. Not bad, you had the methods right, just look at my feedback regarding the time/space complexity.
Comment on lines
+3
to
5
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
Comment on lines
+15
to
17
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def reverse(s) |
There was a problem hiding this comment.
👍 However the space & time complexity are O(n^2) because the slice you do has space/time complexity of O(n)
Comment on lines
+25
to
27
| # # Time complexity: O(1) | ||
| # # Space complexity: O(1) | ||
| def reverse_inplace(s) |
There was a problem hiding this comment.
Also you're using the exact method I told you not to use.
Comment on lines
+35
to
-24
| # # Time complexity: O(n) | ||
| # # Space complexity: O(n) | ||
| def bunny(n) | ||
| raise NotImplementedError, "Method not implemented" |
Comment on lines
+45
to
47
| # # Time complexity: O(n^2) * not sure about this one | ||
| # # Space complexity: O(n^2) * same here? | ||
| def nested(s) |
Comment on lines
+58
to
60
| # # Time complexity: O(n) | ||
| # # Space complexity: O(n^2) | ||
| def search(array, value) |
There was a problem hiding this comment.
This works, but once again the time complexity is O(n^2)
Comment on lines
+71
to
73
| # # Time complexity: O(n) | ||
| # # Space complexity: O(n) | ||
| def is_palindrome(s) |
There was a problem hiding this comment.
This works, but once again the time complexity is O(n^2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chris, I wasn't sure on how to do start the final one, but wanted to get this in. I will try to re-attempt this week. Thanks!