India - Water#36
Open
indiakato wants to merge 4 commits into
Open
Conversation
CheezItMan
reviewed
Nov 4, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work India. You hit the main learning goals. Check out my comments especially regarding the reverse_inplace method.
Comment on lines
+3
to
5
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
Comment on lines
17
to
19
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def reverse(s) |
Comment on lines
+27
to
29
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def reverse_inplace(s) |
There was a problem hiding this comment.
⚠ This method is not reversing the string in place, instead it's creating a new string with each recursive call.
Could you see a way to do it with the following method signature?
Suggested change
| # Time complexity: O(n^2) | |
| # Space complexity: O(n^2) | |
| def reverse_inplace(s) | |
| # Time complexity: O(n^2) | |
| # Space complexity: O(n^2) | |
| def reverse_inplace(s, low = 0, high = s.length - 1) |
Comment on lines
+42
to
44
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n) |
Comment on lines
+55
to
57
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def search(array, value) |
There was a problem hiding this comment.
👍 However can you see how to do this method with O(n) space/time complexity?
| return is_palindrome(s[1..-2]) | ||
| end | ||
| end | ||
|
|
Comment on lines
+67
to
69
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def is_palindrome(s) |
There was a problem hiding this comment.
👍 Similar note to the above on time/space complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.