Skip to content

Earth - Emily#31

Open
emirry wants to merge 2 commits into
Ada-C14:masterfrom
emirry:master
Open

Earth - Emily#31
emirry wants to merge 2 commits into
Ada-C14:masterfrom
emirry:master

Conversation

@emirry
Copy link
Copy Markdown

@emirry emirry commented Nov 3, 2020

No description provided.

Copy link
Copy Markdown

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Emily, you hit the learning goals here. Well done. I do suggest you look at my suggestions and see if you can see ways to convert the methods into O(n) time/space complexity.

Comment thread lib/recursive-methods.rb
Comment on lines +3 to 5
# Time complexity: O(n), where n is the length
# Space complexity: O(n), uses up some space in the call stack until it reaches the base case
def factorial(n)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/recursive-methods.rb
Comment on lines +15 to 17
# Time complexity: O(n^2)
# Space complexity: O(n^2)
def reverse(s)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/recursive-methods.rb
Comment on lines +25 to 27
# Time complexity: O(n)
# Space complexity: O(n)
def reverse_inplace(s)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/recursive-methods.rb
Comment on lines +45 to 47
# Time complexity: O(n)
# Space complexity: O(n)
def bunny(n)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/recursive-methods.rb
Comment on lines +55 to 57
# Time complexity: O(n^2)
# Space complexity: O(n^2)
def nested(s)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However can you see a way, like with reverse_inplace to do it with O(n) time/space complexity?

Comment thread lib/recursive-methods.rb
Comment on lines +70 to 72
# Time complexity: O(n^2)
# Space complexity: O(n^2)
def search(array, value)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However can you see a way, like with reverse_inplace to do it with O(n) time/space complexity?

Comment thread lib/recursive-methods.rb
Comment on lines +82 to 84
# Time complexity: O(n^2)
# Space complexity: O(n^2)
def is_palindrome(s)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However can you see a way, like with reverse_inplace to do it with O(n) time/space complexity?

Comment thread lib/recursive-methods.rb
Comment on lines +94 to 96
# Time complexity: O(n^2)?
# Space complexity: O(n^2)?
def digit_match(n, m)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However can you see a way, like with reverse_inplace to do it with O(n) time/space complexity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants