-
Notifications
You must be signed in to change notification settings - Fork 48
space - Nora #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
space - Nora #44
Conversation
|
I never got wave 3 working, but I wanted to turn something in rather than get too far behind. |
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Even though winner detection was broken everything else worked and your code was generally quite well organized. 😄
| ## Wave 3 | ||
|
|
||
| For wave 3, you will add the game logic to detect if a player has one or if there is a tie (all squares filled and with no winner). To do this you will complete the `checkForWinner` method and display the winner in the `header` section. The game should also cease responding to clicks on the board if the game has a winner. | ||
| For wave 3, you will add the game logic to detect if a player has won or if there is a tie (all squares filled and with no winner). To do this you will complete the `checkForWinner` method and display the winner in the `header` section. The game should also cease responding to clicks on the board if the game has a winner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's legit. I'll go fix that.
| for (let i = 0; i < possibleLines.length; i++) { | ||
| const [a, b, c] = possibleLines[i]; | ||
| if (squares[a] && squares[a] === squares[b] && squares[a] === squares[c]) { | ||
| return squares[a]; | ||
| // return setWinner(activePlayer); | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you tried to get a little too clever here. A bit if/else if statement would have been fine. It's gross but starting with the brute force way is generally a good way to get something working.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.