forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 48
Time - Vera #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
veralizeth
wants to merge
16
commits into
Ada-C13:master
Choose a base branch
from
veralizeth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Time - Vera #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if there is a tie
jmaddox19
reviewed
May 4, 2020
Comment on lines
+87
to
+105
| const checkForWinner = (setSquares) => { | ||
| // Complete in Wave 3 | ||
| // Invoking the function to get a flat array with the values. | ||
| const values = extractValuesFromSquares(setSquares); | ||
|
|
||
| for (let i in WINNINGOPTIONS) { | ||
| // Destructuring (Example winningOptions first Iteration[i] i=0 | ||
| // a = 0, b = 1 c = 2) | ||
| const [a, b, c] = WINNINGOPTIONS[i]; | ||
| // Return the value of the winner | ||
| if (values[a] && values[a] === values[b] && values[a] === values[c]) { | ||
| // Return the value of the winner player. | ||
| return values[a]; | ||
| } else if (!values.includes('')) { | ||
| // Return false is there is tie. | ||
| return false; | ||
| } | ||
| } | ||
| // The game is runnig! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So concise!
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Additional FeedbackGreat work!! Love the pretty styling you added! Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?updateValueis the event handler for clicking on each square. Every time one square is clickedsetPlayer1Turn, display X and Pass the turn to player2. SetPlayer1Turn, now the player1 turn is over.CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.