Time - Vicki #25
Open
Time - Vicki #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Great work! Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
jmaddox19
reviewed
May 4, 2020
Comment on lines
+76
to
+95
| if(squares[0][0].value===squares[0][1].value && squares[0][1].value===squares[0][2].value && squares[0][0].value !==""){ | ||
| setWinner(true); | ||
| showWinner("The winner is " + squares[0][0].value); | ||
|
|
||
| } | ||
| else if | ||
| (squares[1][0].value===squares[1][1].value && squares[1][1].value===squares[1][2].value && squares[1][0].value !==""){ | ||
| setWinner(true); | ||
| showWinner("The winner is " + squares[1][0].value); | ||
| } | ||
| else if | ||
| (squares[2][0].value===squares[2][1].value && squares[2][1].value===squares[2][2].value && squares[2][0].value !==""){ | ||
| setWinner(true); | ||
| showWinner("The winner is " + squares[2][0].value); | ||
| } | ||
| else if | ||
| (squares[0][0].value===squares[1][0].value && squares[1][0].value===squares[2][0].value && squares[0][0].value !==""){ | ||
| setWinner(true); | ||
| showWinner("The winner is " + squares[0][0].value); | ||
| } |
There was a problem hiding this comment.
This certainly works but could be "DRYed" up by setting this up in a loop format.
Comment on lines
+10
to
+18
| [<Square id={squares[0][0].id} value={squares[0][0].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[0][1].id} value={squares[0][1].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[0][2].id} value={squares[0][2].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[1][0].id} value={squares[1][0].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[1][1].id} value={squares[1][1].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[1][2].id} value={squares[1][2].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[2][0].id} value={squares[2][0].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[2][1].id} value={squares[2][1].value} onClickCallback={onClickCallback} />, | ||
| <Square id={squares[2][2].id} value={squares[2][2].value} onClickCallback={onClickCallback} />] |
There was a problem hiding this comment.
This could also be DRYed up with a loop.
jmaddox19
reviewed
May 4, 2020
| // When it is clicked on. | ||
| // Then pass it into the squares as a callback | ||
|
|
||
| const changeSquare = (changedSquare)=>{ |
There was a problem hiding this comment.
The way the program is written, if a play accidentally clicks a space that has already been claimed, they lose their turn. A check could be added to this function to address that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.