forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 48
Space - Diana #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dnguye2
wants to merge
9
commits into
Ada-C13:master
Choose a base branch
from
dnguye2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Space - Diana #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
May 4, 2020
| } | ||
|
|
||
|
|
||
| const checkForWinner = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the comments in here are great for readibility!
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Great work! Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?useStatearray that can change the state. This function is asetStatefunction is a callback function meaning it won't be executed until the event occurs.styleattribute(2) external CSS stylesheet using
classNameInline CSS is recommended to never be used (while quick and easy) and instead we should use an external CSS stylesheet as it is better for performance-- keeps code DRY and efficient
"Think of manipulating the virtual DOM as editing a blueprint, as opposed to moving rooms in an actual house."
When a JSX element is rendered, every virtual DOM object is updated and the cost is insignifcant since the virtual DOM updates quickly. Once that is done, React goes through a process called "diffing" where React compares the virtual DOM with the a snapshot taken before the update. This allows React to know which virtual DOM objects changed.
The changed virtual objects then changes those objects on the real DOM and then the output of the screen changes.
Source: [x]
CS Fundamentals Questions
forloops always run the same amount of times and the input size never changes (8 times for going throughwinningSolutions(plus 3 more times if a winner is not found) and 9 times for each square)Space: O(1)?(not sure since I'm creating a player variable within the for loop to determine a winner...)
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.
Source [x]