Time - Jocelyn #23
Open
Time - Jocelyn #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 3, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit the learning goals here. Take a look at my comment regarding delete but otherwise excellent work.
Comment on lines
+23
to
25
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+37
to
39
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
50
to
52
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+68
to
70
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+85
to
87
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length |
Comment on lines
+101
to
103
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+119
to
121
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+131
to
133
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
There was a problem hiding this comment.
👍 Well done, but what if @tail is nil?
Comment on lines
+152
to
154
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.