Yasmin-Leaves #37
Open
Yasmin-Leaves #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paces and white spaces)
CheezItMan
reviewed
Oct 10, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, but you didn't reverse in place and didn't handle extra spaces in the output. Otherwise not bad. Check out my comments and let me know if you have questions.
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: o(n) | ||
| # Space complexity: o(1) |
There was a problem hiding this comment.
You are doing my_sentence.split which creates a new array of equal size to the string. So... This is O(n) space complexity.
You were asked to do this in place.
| end | ||
| # binding.pry | ||
| # print words | ||
| final_word = words.join(" ") |
There was a problem hiding this comment.
This works, but you assume each word is separated by one space. That's not necessarily true.
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: o(n^2) | ||
| # Space complexity: o(1) |
There was a problem hiding this comment.
Since you do .split this has space complexity of O(n).
| # Space complexity: ? | ||
| # Time complexity: o(n^2) | ||
| # Space complexity: o(1) | ||
| def sort_by_length(my_sentence) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…paces and white spaces)
Sorting & Reverse Sentence