Skip to content

Ports - Laneia #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laneia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ports - Laneia #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
i = 0
Copy link

@ace-n ace-n Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this can probably be declared closer to where it's used 😄


if (array1 == nil && array2 == nil) || (array1 == [] && array2 == [])
Copy link

@ace-n ace-n Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good boundary checking!

Super-tiny nit: it's somewhat explicit though - could we do something more concise, like:

 if (array1 == array2)
   return true
 end

(Aside: some people think explicit code is easier to read, while
others prefer more concise code - so this comment is really a
matter of personal preference. 😄 )

return true
elsif array1 == nil || array2 == nil
return false
end

if array1.length == array2.length
Copy link

@ace-n ace-n Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: nested ifs are harder to understand at a glance. How about something like:

if array1.length != array2.length
  return false
end 

# array lengths presumed equal, because of above "guarding" if statement

...

until i > array1.length
if array1[i] != array2[i]
return false
end
i += 1
Copy link

@ace-n ace-n Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: typically people use a "for" loop here rather than manually doing i += 1 (it's more concise, which makes it easier to identify at a glance)

end
return true
end
return false
end

array3 = [10, 20, 30, 40, 50, 60]
Copy link

@ace-n ace-n Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice testing! 😄

Aside: typically we'll put our tests in a separate file. This is
important because some languages (e.g. Python and Javascript) automatically
execute top-level code in loaded files/libraries.

e.g. if fileB imports fileA, top-level code (that's not in a function)
in fileA will automatically be executed in such languages. (In some cases, this is what you want - in others, it isn't.)

array4 = [10, 20, 30, 40, 50, 60, 70]
p array_equals(array3, array4)