Maria and Shamira #31

MiraMarshall · 2019-05-17T23:27:14Z

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We decided to make a Customers Model, Movie Model and have a Rental Model that joined both the customer_id and movied_id.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	O(n) time complexity depends on the amount of data in the data structure.
What is the Big-O time complexity of the `POST /rentals/check-in` endpoint? What does the time complexity depend on? Explain your reasoning.	O(log(n)) with time complexity depending on how long it takes to use the find_by.
Describe a set of positive and negative test cases you implemented for a model.	We have positive and negative test cases for with and without validations.
Describe a set of positive and negative test cases you implemented for a controller.	We implemented positive and negative test cases for the show methods in all of our controllers.
How does your API respond when bad data is sent to it?	It renders a 404 with an error message.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	They aren't model methods, but we made a custom method for check-in and check-out to track inventory and create rentals.
Do you have any recommendations on how we could improve this project for the next cohort?	We would suggest not having a partner project directly after a 4 person project. So people can have some time to reset after bEtsy. More organized instructions and a little more time working with Postman.
Link to Trello	https://trello.com/b/pv6LNLTC/videostoreapi
Link to ERD
Summary	Overval it was a great activity getting to know people from the other class. It was making an API. It reminded us that we need to study relationships.

👯

👍

Movie controller methods and tests.

YAY

:)

dHelmgren · 2019-05-24T18:47:21Z

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	good
Comprehension questions	good. Need for a break after bEtsy noted.
General
Business Logic in Models	All of your business logic is in your models, see comment on how this could be fixed.
All required endpoints return expected JSON data	Yes
Requests respond with appropriate HTTP Status Code	yes
Errors are reported	yes
Testing
Passes all Smoke Tests	yes
Model Tests - all relations, validations, and custom functions test positive & negative cases	Given that you didn't have logic in your models, these tests covered your cases.
Controller Tests - URI parameters and data in the request body have positive & negative cases	No, see comments.
Overall	This project could have gone better. Doing all of the work of your application in the controller makes a lot of pieces of your app very hard to test, but on top of that the tests that you submitted don't cover many important cases that your app should handle. TDD is part of the Ada bar, so make sure that future projects cover all applicable cases.

dHelmgren · 2019-05-24T17:40:38Z

app/controllers/customers_controller.rb

+  def show
+    customer = Customer.find_by(id: params[:id])
+    if customer
+      render status: :ok, json: customer.as_json(only: [:id, :name, :registered_at, :adress, :city, :state, :postal_code, :phone, :movies_checked_out_count]), status: :ok


Small style note: not all text editors wrap lines for you. This line is so long that on GitHub I have to scroll horizontally to see all the pieces. You can make this easier to read by putting a newline after any given comma in a statement.

dHelmgren · 2019-05-24T17:41:11Z

app/controllers/customers_controller.rb

+    if customer
+      render status: :ok, json: customer.as_json(only: [:id, :name, :registered_at, :adress, :city, :state, :postal_code, :phone, :movies_checked_out_count]), status: :ok
+    else
+      render status: :not_found, json: { ok: false, messages: "Movie was not found!" }


This is a customer... Copy pasta is dangerous!

dHelmgren · 2019-05-24T17:42:03Z

app/controllers/rentals_controller.rb

+  def check_out
+    rental = Rental.new(rental_params)
+    customer = Customer.find_by(id: rental.customer_id)
+    movie = Movie.find_by(id: rental.movie_id)


You have a bunch of business logic here! Would it be possible to encapsulate this in a model method? Something like

rental.check_out(customer_id, movie_id)

might be a good interface. That would make this logic easier to test as well.

dHelmgren · 2019-05-24T18:29:50Z

test/controllers/customers_controller_test.rb

+
+  it "returns json" do
+    get customers_path
+    expect(response.header["Content-Type"]).must_include "json"


This isn't checking the actual JSON to see if the contents are correct.

dHelmgren · 2019-05-24T18:31:52Z

test/controllers/movies_controller_test.rb

+    get movies_index_url
+    value(response).must_be :successful?
+  end
+


What about the show action?

dHelmgren · 2019-05-24T18:43:27Z

test/controllers/rentals_controller_test.rb

+      due_date: Date.today + 7,
+    }
+  }
+  describe "checkout" do


These tests don't cover cases I would expect to see. What if there is bad data? What data is being sent back?

Also, I don't see any tests written for the checkin route.

MiraMarshall and others added 30 commits May 14, 2019 14:36

rails setup

0cf7170

added it works

f638c22

added model validations

930d788

added controllers params

1d66f70

Passing movie model validation tests.

343bfd9

initiated test

49a5460

updated branch removed typo

d3c3cf6

Merge pull request #1 from MiraMarshall/sm_movie_model_validations

b04a886

👯

Merge branch 'master' into customer-model_test

2500df4

Merge pull request #2 from MiraMarshall/customer-model_test

2495d9b

👍

Movie controller methods and tests.

0be9948

Merge pull request #3 from MiraMarshall/sm_movie_controller

9398ef5

Movie controller methods and tests.

generated migration for checkout, duedate and available for rentals

4b4291b

updates-testing

25e4326

updates-testing

954c0d4

test for postman

3ee08df

movies and rentals controllers

5036899

corrected render json

5461cf1

updated model relationship

4076896

Added migration available_inventory to movies

a3f9a16

check_out test passing

fedf02f

passing customer controller tests

a896322

added test for missing date for checkout

7e0e75b

Merge pull request #4 from MiraMarshall/controller_tests_and_inventory

04ccc50

YAY

updates on rental controller test

2f4a042

Merge pull request #5 from MiraMarshall/redo_rental_test

eedb681

:)

Fixed checkout rental controller and inventory count

1516a8b

updates to test and rental controllers

b9344c8

checkout count working

2d0a617

passing all smoke test, yay

73840d9

update after running test again

093779c

dHelmgren reviewed May 24, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Maria and Shamira #31

Maria and Shamira #31

MiraMarshall commented May 17, 2019

Uh oh!

dHelmgren commented May 24, 2019

Uh oh!

dHelmgren May 24, 2019

Uh oh!

dHelmgren May 24, 2019

Uh oh!

dHelmgren May 24, 2019

Uh oh!

dHelmgren May 24, 2019

Uh oh!

dHelmgren May 24, 2019

Uh oh!

dHelmgren May 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Maria and Shamira #31

Are you sure you want to change the base?

Maria and Shamira #31

Conversation

MiraMarshall commented May 17, 2019

Video Store API

Comprehension Questions

Uh oh!

dHelmgren commented May 24, 2019

Video Store

What We're Looking For

Uh oh!

dHelmgren May 24, 2019

Choose a reason for hiding this comment

Uh oh!

dHelmgren May 24, 2019

Choose a reason for hiding this comment

Uh oh!

dHelmgren May 24, 2019

Choose a reason for hiding this comment

Uh oh!

dHelmgren May 24, 2019

Choose a reason for hiding this comment

Uh oh!

dHelmgren May 24, 2019

Choose a reason for hiding this comment

Uh oh!

dHelmgren May 24, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants